| Message ID | 1320865194-9779-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 0e3b800e71cb7759d099eabbd8ad4c4fe848e381 |
| Headers | show |
On Wed, Nov 09, 2011 at 06:59:54PM +0000, Peter Maydell wrote: > Add a missing 'break' statement to fix a buffer overrun when > executing the EEPROM write-all command. Spotted by Coverity > (see bug 887883). > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/lan9118.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches Stefan
diff --git a/hw/lan9118.c b/hw/lan9118.c index 634b88e..f8149e6 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@ -863,6 +863,7 @@ static void lan9118_eeprom_cmd(lan9118_state *s, int cmd, int addr) } else { DPRINTF("EEPROM Write All (ignored)\n"); } + break; case 5: /* ERASE */ if (s->eeprom_writable) { s->eeprom[addr] = 0xff;
Add a missing 'break' statement to fix a buffer overrun when executing the EEPROM write-all command. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/lan9118.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)