| Message ID | 20210817041548.1276-4-linux.amoon@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [PATCHv3,1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node | expand |
Hi Anand, On Tue, Aug 17, 2021 at 6:17 AM Anand Moon <linux.amoon@gmail.com> wrote: > > Fix the chip enable signal changing from Active High to Active Low > to enable input power to USB power. Also updated signal name as per > the schematics. according to [0] (page 12) Odroid-C2 uses an "RT9715EGB" for USB OTG power The datasheet for that power switch [1] mentions on page page 1 that the "E" stands for "E : 1.1A/Active High" Can you please elaborate how you have tested this to confirm that active low is the correct polarity? Best regards, Martin [0] https://dn.odroid.com/S905/Schematic/odroid-c2_rev0.1_20150930.pdf [1] https://www.richtek.com/assets/product_file/RT9715/DS9715-03.pdf
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 201596247fd9..3f4f16a5dedd 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -38,12 +38,11 @@ usb_otg_pwr: regulator-usb-pwrs { regulator-max-microvolt = <5000000>; /* - * signal name from schematics: PWREN + * signal name from schematics: PWREN - GPIOAO.BIT5 */ - gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; - enable-active-high; + gpios = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_LOW>; /* - * signal name from schematics: USB_POWER + * signal name from schematics: USB_POWER - P5V0 */ vin-supply = <&p5v0>; };
Fix the chip enable signal changing from Active High to Active Low to enable input power to USB power. Also updated signal name as per the schematics. Fixes: 5a0803bd5ae2 ("ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes") Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- v2: Fix the typo: shematics -> schematics --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)