| Message ID | 20210805140231.268273-1-thomas.perrot@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | bus: mhi: pci_generic: increase timeout value for operations to 24000ms | expand |
On Thu, 5 Aug 2021 at 16:04, Thomas Perrot <thomas.perrot@bootlin.com> wrote: > > Otherwise, the waiting time was too short to use a Sierra Wireless EM919X > connected to an i.MX6 through the PCIe bus. > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
On Thu, Aug 05, 2021 at 04:02:31PM +0200, Thomas Perrot wrote: > Otherwise, the waiting time was too short to use a Sierra Wireless EM919X > connected to an i.MX6 through the PCIe bus. > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/bus/mhi/pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c > index 4dd1077354af..e08ed6e5031b 100644 > --- a/drivers/bus/mhi/pci_generic.c > +++ b/drivers/bus/mhi/pci_generic.c > @@ -248,7 +248,7 @@ static struct mhi_event_config modem_qcom_v1_mhi_events[] = { > > static const struct mhi_controller_config modem_qcom_v1_mhiv_config = { > .max_channels = 128, > - .timeout_ms = 8000, > + .timeout_ms = 24000, > .num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels), > .ch_cfg = modem_qcom_v1_mhi_channels, > .num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events), > -- > 2.31.1 >
Hello Manivannan, I just saw that this patch seems not yet been merged, is there a issue with it? Best regards, Thomas On Mon, 2021-08-16 at 09:52 +0530, Manivannan Sadhasivam wrote: > On Thu, Aug 05, 2021 at 04:02:31PM +0200, Thomas Perrot wrote: > > Otherwise, the waiting time was too short to use a Sierra Wireless > > EM919X > > connected to an i.MX6 through the PCIe bus. > > > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Thanks, > Mani > > > --- > > drivers/bus/mhi/pci_generic.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/bus/mhi/pci_generic.c > > b/drivers/bus/mhi/pci_generic.c > > index 4dd1077354af..e08ed6e5031b 100644 > > --- a/drivers/bus/mhi/pci_generic.c > > +++ b/drivers/bus/mhi/pci_generic.c > > @@ -248,7 +248,7 @@ static struct mhi_event_config > > modem_qcom_v1_mhi_events[] = { > > > > static const struct mhi_controller_config > > modem_qcom_v1_mhiv_config = { > > .max_channels = 128, > > - .timeout_ms = 8000, > > + .timeout_ms = 24000, > > .num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels), > > .ch_cfg = modem_qcom_v1_mhi_channels, > > .num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events), > > -- > > 2.31.1 > > -- Thomas Perrot, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Hi Thomas, On 29 September 2021 1:41:12 AM IST, Thomas Perrot <thomas.perrot@bootlin.com> wrote: >Hello Manivannan, > >I just saw that this patch seems not yet been merged, is there a issue >with it? > For the last merge window we had a conflict with netdev tree so I was not able to send the second iteration of the PR. Will apply this patch for v5.16. Thanks, Mani >Best regards, >Thomas > >On Mon, 2021-08-16 at 09:52 +0530, Manivannan Sadhasivam wrote: >> On Thu, Aug 05, 2021 at 04:02:31PM +0200, Thomas Perrot wrote: >> > Otherwise, the waiting time was too short to use a Sierra Wireless >> > EM919X >> > connected to an i.MX6 through the PCIe bus. >> > >> > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> >> >> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> >> Thanks, >> Mani >> >> > --- >> > drivers/bus/mhi/pci_generic.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/bus/mhi/pci_generic.c >> > b/drivers/bus/mhi/pci_generic.c >> > index 4dd1077354af..e08ed6e5031b 100644 >> > --- a/drivers/bus/mhi/pci_generic.c >> > +++ b/drivers/bus/mhi/pci_generic.c >> > @@ -248,7 +248,7 @@ static struct mhi_event_config >> > modem_qcom_v1_mhi_events[] = { >> > >> > static const struct mhi_controller_config >> > modem_qcom_v1_mhiv_config = { >> > .max_channels = 128, >> > - .timeout_ms = 8000, >> > + .timeout_ms = 24000, >> > .num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels), >> > .ch_cfg = modem_qcom_v1_mhi_channels, >> > .num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events), >> > -- >> > 2.31.1 >> > > -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
On Thu, Sep 30, 2021 at 10:07:57AM +0200, Thomas Perrot wrote: > Hello, > [...] > I made experimentation on a Sierra EM9190 (SDX55) engineering sample, > using a old development firmware. > > So, I agree that setting the same timeout of 24000ms for all modems, is > not necessarily relevant. > However, the current default value seems too low, in view of timeouts > used on vendor-branded, then using a higher value seems relevant. > > Moreover, Sierra EM919x modems use a custom controller configuration, > we are currently working on it. As our tests not being sufficiently > conclusive, so we have not yet submitted. > Okay. Then please add a separate config for this device when you have it. It makes more sense to have the longer timeout only for devices that need it. Thanks, Mani > Best regards, > Thomas > > > > > > > It was derived from testing I believe. > > > > Following your reasoning above, shouldn't this 24000ms timeout be > > applied only to the Sierra Wireless EM91xx devices (which may have > > custom firmware bits delaying the initialization a bit longer), and > > not to the generic SDX24, SDX55 and SDX65? > > > > If I'm not mistaken, Thomas is testing with a custom mhi_pci_generic > > entry for the EM91xx; as in > > https://forum.sierrawireless.com/t/sierra-wireless-airprime-em919x-pcie-support/24927 > > . > > I'm also playing with that same entry on my own setup, but have other > > problems of my own :) > > > > > > -- > > Aleksander > > https://aleksander.es > > -- > Thomas Perrot, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com >
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c index 4dd1077354af..e08ed6e5031b 100644 --- a/drivers/bus/mhi/pci_generic.c +++ b/drivers/bus/mhi/pci_generic.c @@ -248,7 +248,7 @@ static struct mhi_event_config modem_qcom_v1_mhi_events[] = { static const struct mhi_controller_config modem_qcom_v1_mhiv_config = { .max_channels = 128, - .timeout_ms = 8000, + .timeout_ms = 24000, .num_channels = ARRAY_SIZE(modem_qcom_v1_mhi_channels), .ch_cfg = modem_qcom_v1_mhi_channels, .num_events = ARRAY_SIZE(modem_qcom_v1_mhi_events),
Otherwise, the waiting time was too short to use a Sierra Wireless EM919X connected to an i.MX6 through the PCIe bus. Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> --- drivers/bus/mhi/pci_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)