diff mbox series

[v4] pktgen: Remove redundant clone_skb override

Message ID 20210803162739.2363542-1-richardsonnick@google.com
State New
Headers show
Series [v4] pktgen: Remove redundant clone_skb override | expand

Commit Message

Nicholas Richardson Aug. 3, 2021, 4:27 p.m. UTC 
From: Nick Richardson <richardsonnick@google.com>

When the netif_receive xmit_mode is set, a line is supposed to set
clone_skb to a default 0 value. This line is made redundant due to a
preceding line that checks if clone_skb is more than zero and returns
-ENOTSUPP.

Overriding clone_skb to 0 does not make any difference to the behavior
because if it was positive we return error. So it can be either 0 or
negative, and in both cases the behavior is the same.

Remove redundant line that sets clone_skb to zero.

Signed-off-by: Nick Richardson <richardsonnick@google.com>
---
 net/core/pktgen.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 4, 2021, noon UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue,  3 Aug 2021 16:27:35 +0000 you wrote:
> From: Nick Richardson <richardsonnick@google.com>

> 

> When the netif_receive xmit_mode is set, a line is supposed to set

> clone_skb to a default 0 value. This line is made redundant due to a

> preceding line that checks if clone_skb is more than zero and returns

> -ENOTSUPP.

> 

> [...]


Here is the summary with links:
  - [v4] pktgen: Remove redundant clone_skb override
    https://git.kernel.org/netdev/net-next/c/c2eecaa193ff

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 7e258d255e90..314f97acf39d 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1190,11 +1190,6 @@  static ssize_t pktgen_if_write(struct file *file,
 			 * pktgen_xmit() is called
 			 */
 			pkt_dev->last_ok = 1;
-
-			/* override clone_skb if user passed default value
-			 * at module loading time
-			 */
-			pkt_dev->clone_skb = 0;
 		} else if (strcmp(f, "queue_xmit") == 0) {
 			pkt_dev->xmit_mode = M_QUEUE_XMIT;
 			pkt_dev->last_ok = 1;