diff mbox series

[5/5] arm64: dts: rockchip: rk3568-evb1-v10: add node for sd card

Message ID 20210803185309.10013-6-michael.riesch@wolfvision.net
State Superseded
Headers show
Series [1/5] arm64: dts: rockchip: rk3568-evb1-v10: add regulators of rk809 pmic | expand

Commit Message

Michael Riesch Aug. 3, 2021, 6:53 p.m. UTC
Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Heiko Stübner Aug. 3, 2021, 8:48 p.m. UTC | #1
Am Dienstag, 3. August 2021, 20:53:09 CEST schrieb Michael Riesch:
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> index 3ac70a8183c4..b0f5aa8c979c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> @@ -17,6 +17,7 @@
>  		ethernet0 = &gmac0;
>  		ethernet1 = &gmac1;
>  		emmc = &sdhci;
> +		sd = &sdmmc0;

same thing as in the previous patch.

I guess you may want something like

	mmc0 = &sdhci;
	mmc1 = &sdmmc0;

maybe?


Heiko

>  	};
>  
>  	chosen: chosen {
> @@ -353,6 +354,20 @@
>  	status = "okay";
>  };
>  
> +&sdmmc0 {
> +	bus-width = <4>;
> +	cap-sd-highspeed;
> +	cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
> +	disable-wp;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> +	sd-uhs-sdr104;
> +	supports-sd;
> +	vmmc-supply = <&vcc3v3_sd>;
> +	vqmmc-supply = <&vccio_sd>;
> +	status = "okay";
> +};
> +
>  &uart2 {
>  	status = "okay";
>  };
>
Michael Riesch Aug. 4, 2021, 10:03 a.m. UTC | #2
Hi Heiko,

On 8/3/21 10:48 PM, Heiko Stübner wrote:
> Am Dienstag, 3. August 2021, 20:53:09 CEST schrieb Michael Riesch:

>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

>> ---

>>  arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 15 +++++++++++++++

>>  1 file changed, 15 insertions(+)

>>

>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts

>> index 3ac70a8183c4..b0f5aa8c979c 100644

>> --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts

>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts

>> @@ -17,6 +17,7 @@

>>  		ethernet0 = &gmac0;

>>  		ethernet1 = &gmac1;

>>  		emmc = &sdhci;

>> +		sd = &sdmmc0;

> 

> same thing as in the previous patch.

> 

> I guess you may want something like

> 

> 	mmc0 = &sdhci;

> 	mmc1 = &sdmmc0;

> 

> maybe?


Thanks for the suggestion, I'll include it in the v2.

Regards, Michael

> 

> 

> Heiko

> 

>>  	};

>>  

>>  	chosen: chosen {

>> @@ -353,6 +354,20 @@

>>  	status = "okay";

>>  };

>>  

>> +&sdmmc0 {

>> +	bus-width = <4>;

>> +	cap-sd-highspeed;

>> +	cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;

>> +	disable-wp;

>> +	pinctrl-names = "default";

>> +	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;

>> +	sd-uhs-sdr104;

>> +	supports-sd;

>> +	vmmc-supply = <&vcc3v3_sd>;

>> +	vqmmc-supply = <&vccio_sd>;

>> +	status = "okay";

>> +};

>> +

>>  &uart2 {

>>  	status = "okay";

>>  };

>>

> 

> 

> 

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
index 3ac70a8183c4..b0f5aa8c979c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
@@ -17,6 +17,7 @@ 
 		ethernet0 = &gmac0;
 		ethernet1 = &gmac1;
 		emmc = &sdhci;
+		sd = &sdmmc0;
 	};
 
 	chosen: chosen {
@@ -353,6 +354,20 @@ 
 	status = "okay";
 };
 
+&sdmmc0 {
+	bus-width = <4>;
+	cap-sd-highspeed;
+	cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
+	disable-wp;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
+	sd-uhs-sdr104;
+	supports-sd;
+	vmmc-supply = <&vcc3v3_sd>;
+	vqmmc-supply = <&vccio_sd>;
+	status = "okay";
+};
+
 &uart2 {
 	status = "okay";
 };