diff mbox series

[v3,11/20] ASoC: dt-bindings: q6dsp: add q6apm-bedai compatible

Message ID 20210803125411.28066-12-srinivas.kandagatla@linaro.org
State Superseded
Headers show
Series ASoC: qcom: Add AudioReach support | expand

Commit Message

Srinivas Kandagatla Aug. 3, 2021, 12:54 p.m. UTC 
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---
 .../sound/qcom,q6dsp-audio-ports.yaml         | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

-- 
2.21.0

Comments

Mark Brown Aug. 4, 2021, 6:01 p.m. UTC | #1 
On Tue, Aug 03, 2021 at 01:54:02PM +0100, Srinivas Kandagatla wrote:

> +    enum:

> +      - qcom,q6afe-dais

> +      - qcom,q6apm-bedais


What do these compatibles mean?  The bedais is sounding suspicously like
putting DPCM into DT bindings...
Srinivas Kandagatla Aug. 5, 2021, 9:16 a.m. UTC | #2 
Thanks Mark for the review,

On 04/08/2021 19:01, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 01:54:02PM +0100, Srinivas Kandagatla wrote:

> 

>> +    enum:

>> +      - qcom,q6afe-dais

>> +      - qcom,q6apm-bedais

> 

> What do these compatibles mean?  The bedais is sounding suspicously like

> putting DPCM into DT bindings...



Old Elite QDSP framework has service called "Audio Front Ends" aka q6afe 
which is responsible for managing the LPASS Audio Ports and Post 
Processing. We endup with "qcom,q6afe-dais" in the past to represent the 
LPASS audio ports.

With New AudioReach framework this functionality is managed by "Audio 
Process Manager" aka q6apm.

I will rename "qcom,q6apm-bedais" to "qcom,q6apm-lpaif"

to be more explicit about the hardware LPAIF(Low Power Audio Interface 
Modules) IP.

--srini


>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-ports.yaml b/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-ports.yaml
index 6990295803a8..521256339909 100644
--- a/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-ports.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-ports.yaml
@@ -14,7 +14,9 @@  description: |
 
 properties:
   compatible:
-    const: qcom,q6afe-dais
+    enum:
+      - qcom,q6afe-dais
+      - qcom,q6apm-bedais
 
   reg:
     maxItems: 1
@@ -168,6 +170,29 @@  examples:
               #size-cells = <0>;
               #sound-dai-cells = <1>;
 
+              dai@22 {
+                reg = <QUATERNARY_MI2S_RX>;
+                qcom,sd-lines = <0 1 2 3>;
+              };
+            };
+        };
+      };
+  - |
+    #include <dt-bindings/soc/qcom,gpr.h>
+    gpr {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        gpr-service@1 {
+            reg = <GPR_APM_MODULE_IID>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            q6apmdai@1 {
+              compatible = "qcom,q6apm-bedais";
+              reg = <1>;
+              #address-cells = <1>;
+              #size-cells = <0>;
+              #sound-dai-cells = <1>;
+
               dai@22 {
                 reg = <QUATERNARY_MI2S_RX>;
                 qcom,sd-lines = <0 1 2 3>;