diff mbox series

[1/9] ARM: dts: bcm2711: fix emmc2bus node name

Message ID 1627820932-7247-2-git-send-email-stefan.wahren@i2se.com
State New
Headers show
Series ARM: dts: Add Raspberry Pi CM4 & CM4 IO Board support | expand

Commit Message

Stefan Wahren Aug. 1, 2021, 12:28 p.m. UTC
Fix the node name to get the rid of the following DT schema warning:
'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)
(@[0-9a-f]+)?$'

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 arch/arm/boot/dts/bcm2711.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc Zyngier Aug. 2, 2021, 10:25 a.m. UTC | #1
On 2021-08-01 13:28, Stefan Wahren wrote:
> Fix the node name to get the rid of the following DT schema warning:

> 'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)

> (@[0-9a-f]+)?$'

> 

> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>

> ---

>  arch/arm/boot/dts/bcm2711.dtsi | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/bcm2711.dtsi 

> b/arch/arm/boot/dts/bcm2711.dtsi

> index b8a4096..afe0ef8 100644

> --- a/arch/arm/boot/dts/bcm2711.dtsi

> +++ b/arch/arm/boot/dts/bcm2711.dtsi

> @@ -405,7 +405,7 @@

>  	 * The firmware will find whether the emmc2bus alias is defined, and 

> if

>  	 * so, it'll edit the dma-ranges property below accordingly.

>  	 */

> -	emmc2bus: emmc2bus {

> +	emmc2bus: emmc2-bus {


There was a recent breakage on rk3399 because of a similar change.

This is a userspace visible change (it affects the sysfs paths),
which will break people's scripts. It would be a lot better to
add an annotation to the DT to acknowledge the issue and keep
the checker quiet.

         M.
-- 
Jazz is not dead. It just smells funny...
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index b8a4096..afe0ef8 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -405,7 +405,7 @@ 
 	 * The firmware will find whether the emmc2bus alias is defined, and if
 	 * so, it'll edit the dma-ranges property below accordingly.
 	 */
-	emmc2bus: emmc2bus {
+	emmc2bus: emmc2-bus {
 		compatible = "simple-bus";
 		#address-cells = <2>;
 		#size-cells = <1>;