diff mbox series

[net] can: hi311x: fix a signedness bug in hi3110_cmd()

Message ID 20210729141246.GA1267@kili
State New
Headers show
Series [net] can: hi311x: fix a signedness bug in hi3110_cmd() | expand

Commit Message

Dan Carpenter July 29, 2021, 2:12 p.m. UTC 
The hi3110_cmd() is supposed to return zero on success and negative
error codes on failure, but it was accidentally declared as a u8 when
it needs to be an int type.

Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/can/spi/hi311x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc Kleine-Budde July 30, 2021, 6:48 a.m. UTC | #1 
On 29.07.2021 17:12:46, Dan Carpenter wrote:
> The hi3110_cmd() is supposed to return zero on success and negative

> error codes on failure, but it was accidentally declared as a u8 when

> it needs to be an int type.

> 

> Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>


Applied to linux-can/testing.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
diff mbox series

Patch

diff --git a/drivers/net/can/spi/hi311x.c b/drivers/net/can/spi/hi311x.c
index dd17b8c53e1c..89d9c986a229 100644
--- a/drivers/net/can/spi/hi311x.c
+++ b/drivers/net/can/spi/hi311x.c
@@ -218,7 +218,7 @@  static int hi3110_spi_trans(struct spi_device *spi, int len)
 	return ret;
 }
 
-static u8 hi3110_cmd(struct spi_device *spi, u8 command)
+static int hi3110_cmd(struct spi_device *spi, u8 command)
 {
 	struct hi3110_priv *priv = spi_get_drvdata(spi);