diff mbox series

[v1.1,1/2] PCI: PM: Avoid forcing PCI_D0 for wakeup reasons inconsistently

Message ID 2593738.mvXUDI8C0e@kreacher
State New
Headers show
Series PCI: PM: Fix handling of device that can only signal PME from D3cold | expand

Commit Message

Rafael J. Wysocki July 29, 2021, 3:54 p.m. UTC 
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

It is inconsistent to return PCI_D0 from pci_target_state() instead
of the original target state if 'wakeup' is true and the device
cannot signal PME from D0.

This only happens when the device cannot signal PME from the original
target state and any shallower power states (including D0) and that
case is effectively equivalent to the one in which PME singaling is
not supported at all.  Since the original target state is returned in
the latter case, make the function do that in the former one too.

Link: https://lore.kernel.org/linux-pm/3149540.aeNJFYEL58@kreacher/
Fixes: 666ff6f83e1d ("PCI/PM: Avoid using device_may_wakeup() for runtime PM")
Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reported-by: Utkarsh H Patel <utkarsh.h.patel@intel.com>
Reported-by: Koba Ko <koba.ko@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

v1 -> v1.1
      * Resend under a suitable subject.

---
 drivers/pci/pci.c |   16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

Comments

Mika Westerberg July 30, 2021, 10:26 a.m. UTC | #1 
On Thu, Jul 29, 2021 at 05:54:28PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> 

> It is inconsistent to return PCI_D0 from pci_target_state() instead

> of the original target state if 'wakeup' is true and the device

> cannot signal PME from D0.

> 

> This only happens when the device cannot signal PME from the original

> target state and any shallower power states (including D0) and that

> case is effectively equivalent to the one in which PME singaling is

> not supported at all.  Since the original target state is returned in

> the latter case, make the function do that in the former one too.

> 

> Link: https://lore.kernel.org/linux-pm/3149540.aeNJFYEL58@kreacher/

> Fixes: 666ff6f83e1d ("PCI/PM: Avoid using device_may_wakeup() for runtime PM")

> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>


Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff mbox series

Patch

Index: linux-pm/drivers/pci/pci.c
===================================================================
--- linux-pm.orig/drivers/pci/pci.c
+++ linux-pm/drivers/pci/pci.c
@@ -2595,16 +2595,20 @@  static pci_power_t pci_target_state(stru
 	if (dev->current_state == PCI_D3cold)
 		target_state = PCI_D3cold;
 
-	if (wakeup) {
+	if (wakeup && dev->pme_support) {
+		pci_power_t state = target_state;
+
 		/*
 		 * Find the deepest state from which the device can generate
 		 * PME#.
 		 */
-		if (dev->pme_support) {
-			while (target_state
-			      && !(dev->pme_support & (1 << target_state)))
-				target_state--;
-		}
+		while (state && !(dev->pme_support & (1 << state)))
+			state--;
+
+		if (state)
+			return state;
+		else if (dev->pme_support & 1)
+			return PCI_D0;
 	}
 
 	return target_state;