| Message ID | 20210728122808.156961-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | nfc: s3fwrn5: fix uninitialized ERRNO variable in probe error message | expand |
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c index 1421ffd46d9a..1e506f6be96e 100644 --- a/drivers/nfc/s3fwrn5/firmware.c +++ b/drivers/nfc/s3fwrn5/firmware.c @@ -421,9 +421,10 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info) tfm = crypto_alloc_shash("sha1", 0, 0); if (IS_ERR(tfm)) { + ret = PTR_ERR(tfm); dev_err(&fw_info->ndev->nfc_dev->dev, "Cannot allocate shash (code=%d)\n", ret); - return PTR_ERR(tfm); + return ret; } ret = crypto_shash_tfm_digest(tfm, fw->image, image_size, hash_data);
Commit a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label") removed assignment to "ret" variable but it is used right after in dev_err() in the error path. This fixes clang warning: drivers/nfc/s3fwrn5/firmware.c:424:3: warning: 3rd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage] Fixes: a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Commit hash a0302ff5906a from net-next (not Linus' tree). --- drivers/nfc/s3fwrn5/firmware.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)