diff mbox series

[V2] media: uvcvideo: Remove unused including <linux/version.h>

Message ID 20210727092854.1006-1-caihuoqing@baidu.com
State Accepted
Commit ae0334e0cb737e1ddfcae9acdcf4d2adf005f329
Headers show
Series [V2] media: uvcvideo: Remove unused including <linux/version.h> | expand

Commit Message

Cai,Huoqing July 27, 2021, 9:28 a.m. UTC
Remove including <linux/version.h> that don't need it.

V1->V2: Split the patch in two.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Randy Dunlap July 27, 2021, 8:49 p.m. UTC | #1
On 7/27/21 2:28 AM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
> 
> V1->V2: Split the patch in two
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

as reported by 'make versioncheck':

../drivers/soc/tegra/powergate-bpmp.c: 10 linux/version.h not needed.

thanks.

> ---
>  drivers/soc/tegra/powergate-bpmp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c
> index 06c792bafca5..8eaf50d0b6af 100644
> --- a/drivers/soc/tegra/powergate-bpmp.c
> +++ b/drivers/soc/tegra/powergate-bpmp.c
> @@ -7,7 +7,6 @@
>  #include <linux/platform_device.h>
>  #include <linux/pm_domain.h>
>  #include <linux/slab.h>
> -#include <linux/version.h>
>  
>  #include <soc/tegra/bpmp.h>
>  #include <soc/tegra/bpmp-abi.h>
>
Laurent Pinchart July 28, 2021, 5:45 a.m. UTC | #2
Hi Cai,

Thank you for the patch.

On Tue, Jul 27, 2021 at 05:28:53PM +0800, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.

> 

> V1->V2: Split the patch in two.

> 

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>


Taken in my tree for v5.15. Thank you.

> ---

>  drivers/media/usb/uvc/uvc_driver.c | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c

> index 9a791d8ef200..b1b055784f8d 100644

> --- a/drivers/media/usb/uvc/uvc_driver.c

> +++ b/drivers/media/usb/uvc/uvc_driver.c

> @@ -16,7 +16,6 @@

>  #include <linux/videodev2.h>

>  #include <linux/vmalloc.h>

>  #include <linux/wait.h>

> -#include <linux/version.h>

>  #include <asm/unaligned.h>

>  

>  #include <media/v4l2-common.h>


-- 
Regards,

Laurent Pinchart
diff mbox series

Patch

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 9a791d8ef200..b1b055784f8d 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -16,7 +16,6 @@ 
 #include <linux/videodev2.h>
 #include <linux/vmalloc.h>
 #include <linux/wait.h>
-#include <linux/version.h>
 #include <asm/unaligned.h>
 
 #include <media/v4l2-common.h>