diff mbox series

[PULL,for-6.1,10/12] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write

Message ID 20210726214729.2062862-11-richard.henderson@linaro.org
State Accepted
Commit 984178d86b92be23b0efb6da769f22adb08cb83a
Headers show
Series tcg and misc patch queue | expand

Commit Message

Richard Henderson July 26, 2021, 9:47 p.m. UTC 
From clang-13:
hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \
    [-Werror,-Wunused-but-set-variable]

It's pretty clear that we meant to write back 'v' after
all that computation and not 'val'.

Acked-by: David Gibson <david@gibson.dropbear.id.au>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 hw/pci-host/pnv_phb4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1
diff mbox series

Patch

diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 54f57c660a..5c375a9f28 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -392,7 +392,7 @@  static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
             v &= 0xffffffffffff0000ull;
             v |= 0x000000000000cfffull & val;
         }
-        *tptr = val;
+        *tptr = v;
         break;
     }
     case IODA3_TBL_MBT: