| Message ID | 20210720141539.7716-1-tangbin@cmss.chinamobile.com |
|---|---|
| State | Accepted |
| Commit | 391719dce5ebd416347f35d7a136feb6a04cecb8 |
| Headers | show |
| Series | power: supply: qcom_smbb: Remove superfluous error message | expand |
On Tue 20 Jul 09:15 CDT 2021, Tang Bin wrote: > In the probe function, when get irq failed, the function > platform_get_irq_byname() logs an error message, so remove > redundant message here. > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> This says "Zhang certified this patch's origin, then you took the patch and you certified it's origin" - per Documentation/process/submitting-patches.rst But you, Tang, is the author or the patch, so how can Zhang have touched it before you wrote it? Perhaps you worked on it together? In which case you should include a Co-developed-by to indicate this. Both commit message and patch looks good though! Regards, Bjorn > --- > drivers/power/supply/qcom_smbb.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c > index c890e1cec..84cc9fba0 100644 > --- a/drivers/power/supply/qcom_smbb.c > +++ b/drivers/power/supply/qcom_smbb.c > @@ -929,11 +929,8 @@ static int smbb_charger_probe(struct platform_device *pdev) > int irq; > > irq = platform_get_irq_byname(pdev, smbb_charger_irqs[i].name); > - if (irq < 0) { > - dev_err(&pdev->dev, "failed to get irq '%s'\n", > - smbb_charger_irqs[i].name); > + if (irq < 0) > return irq; > - } > > smbb_charger_irqs[i].handler(irq, chg); > > -- > 2.20.1.windows.1 > > >
Hi, Bjorn Andersson: On 2021/7/20 23:52, Bjorn Andersson wrote: > On Tue 20 Jul 09:15 CDT 2021, Tang Bin wrote: > >> In the probe function, when get irq failed, the function >> platform_get_irq_byname() logs an error message, so remove >> redundant message here. >> >> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> >> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > This says "Zhang certified this patch's origin, then you took the patch > and you certified it's origin" - per Documentation/process/submitting-patches.rst > > But you, Tang, is the author or the patch, so how can Zhang have touched > it before you wrote it? > > Perhaps you worked on it together? In which case you should include a > Co-developed-by to indicate this. I am sorry for the late reply to your email due to some reasons. The correct way to write it should be as follows: Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > > Both commit message and patch looks good though! > whether should I send v2 for this patch？ Thanks Tang Bin >> --- >> drivers/power/supply/qcom_smbb.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c >> index c890e1cec..84cc9fba0 100644 >> --- a/drivers/power/supply/qcom_smbb.c >> +++ b/drivers/power/supply/qcom_smbb.c >> @@ -929,11 +929,8 @@ static int smbb_charger_probe(struct platform_device *pdev) >> int irq; >> >> irq = platform_get_irq_byname(pdev, smbb_charger_irqs[i].name); >> - if (irq < 0) { >> - dev_err(&pdev->dev, "failed to get irq '%s'\n", >> - smbb_charger_irqs[i].name); >> + if (irq < 0) >> return irq; >> - } >> >> smbb_charger_irqs[i].handler(irq, chg); >> >> -- >> 2.20.1.windows.1 >> >> >>
Hi, On Mon, Jul 26, 2021 at 09:16:15AM +0800, tangbin wrote: > Hi, Bjorn Andersson: > > On 2021/7/20 23:52, Bjorn Andersson wrote: > > On Tue 20 Jul 09:15 CDT 2021, Tang Bin wrote: > > > > > In the probe function, when get irq failed, the function > > > platform_get_irq_byname() logs an error message, so remove > > > redundant message here. > > > > > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > This says "Zhang certified this patch's origin, then you took the patch > > and you certified it's origin" - per Documentation/process/submitting-patches.rst > > > > But you, Tang, is the author or the patch, so how can Zhang have touched > > it before you wrote it? > > > > Perhaps you worked on it together? In which case you should include a > > Co-developed-by to indicate this. > > I am sorry for the late reply to your email due to some reasons. The correct > way to write it should be as follows: > > Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > > > > > > Both commit message and patch looks good though! > > > whether should I send v2 for this patch？ Thanks, I queued the patch with the Co-developed-by tag. -- Sebastian > > Thanks > > Tang Bin > > > > --- > > > drivers/power/supply/qcom_smbb.c | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c > > > index c890e1cec..84cc9fba0 100644 > > > --- a/drivers/power/supply/qcom_smbb.c > > > +++ b/drivers/power/supply/qcom_smbb.c > > > @@ -929,11 +929,8 @@ static int smbb_charger_probe(struct platform_device *pdev) > > > int irq; > > > irq = platform_get_irq_byname(pdev, smbb_charger_irqs[i].name); > > > - if (irq < 0) { > > > - dev_err(&pdev->dev, "failed to get irq '%s'\n", > > > - smbb_charger_irqs[i].name); > > > + if (irq < 0) > > > return irq; > > > - } > > > smbb_charger_irqs[i].handler(irq, chg); > > > -- > > > 2.20.1.windows.1 > > > > > > > > > > >
diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c index c890e1cec..84cc9fba0 100644 --- a/drivers/power/supply/qcom_smbb.c +++ b/drivers/power/supply/qcom_smbb.c @@ -929,11 +929,8 @@ static int smbb_charger_probe(struct platform_device *pdev) int irq; irq = platform_get_irq_byname(pdev, smbb_charger_irqs[i].name); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get irq '%s'\n", - smbb_charger_irqs[i].name); + if (irq < 0) return irq; - } smbb_charger_irqs[i].handler(irq, chg);