diff mbox series

dt-bindings: Remove "status" from schema examples

Message ID 20210720172025.363238-1-robh@kernel.org
State Accepted
Commit 61aaaa8110b1207cd70313e219cd8d2ed843b8e3
Headers show
Series dt-bindings: Remove "status" from schema examples | expand

Commit Message

Rob Herring (Arm) July 20, 2021, 5:20 p.m. UTC
There's no reason to have "status" properties in examples. "okay" is the
default, and "disabled" turns off some schema checks ('required'
specifically).

Enabling qca,ar71xx causes a warning, so let's fix the node names:

Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property
        From schema: schemas/phy/phy-provider.yaml

Cc: Maxime Ripard <mripard@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Rui Miguel Silva <rmfrfs@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Robert Marko <robert.marko@sartura.hr>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>
Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: ChiYuan Huang <cy_huang@richtek.com>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Dilip Kota <eswara.kota@linux.intel.com>
Cc: Karol Gugala <kgugala@antmicro.com>
Cc: Mateusz Holenko <mholenko@antmicro.com>
Cc: Olivier Moysan <olivier.moysan@st.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-rtc@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Signed-off-by: Rob Herring <robh@kernel.org>

---
 .../display/allwinner,sun8i-a83t-dw-hdmi.yaml |  2 --
 .../display/panel/boe,tv101wum-nl6.yaml       |  1 -
 .../bindings/media/nxp,imx7-mipi-csi2.yaml    |  2 --
 .../bindings/media/renesas,drif.yaml          |  1 -
 .../bindings/net/intel,dwmac-plat.yaml        |  2 --
 .../bindings/net/intel,ixp4xx-ethernet.yaml   |  2 --
 .../bindings/net/nfc/samsung,s3fwrn5.yaml     |  3 ---
 .../devicetree/bindings/net/qca,ar71xx.yaml   | 25 ++++---------------
 .../regulator/richtek,rt6245-regulator.yaml   |  1 -
 .../regulator/vqmmc-ipq4019-regulator.yaml    |  1 -
 .../reset/hisilicon,hi3660-reset.yaml         |  1 -
 .../bindings/reset/intel,rcu-gw.yaml          |  1 -
 .../bindings/rtc/microcrystal,rv3032.yaml     |  1 -
 .../soc/litex/litex,soc-controller.yaml       |  1 -
 .../bindings/sound/st,stm32-sai.yaml          |  2 --
 .../bindings/sound/ti,j721e-cpb-audio.yaml    |  2 --
 .../sound/ti,j721e-cpb-ivi-audio.yaml         |  2 --
 17 files changed, 5 insertions(+), 45 deletions(-)

-- 
2.27.0

Comments

Mauro Carvalho Chehab July 20, 2021, 5:49 p.m. UTC | #1
Em Tue, 20 Jul 2021 11:20:25 -0600
Rob Herring <robh@kernel.org> escreveu:

> There's no reason to have "status" properties in examples. "okay" is the

> default, and "disabled" turns off some schema checks ('required'

> specifically).

> 

> Enabling qca,ar71xx causes a warning, so let's fix the node names:

> 

> Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property

>         From schema: schemas/phy/phy-provider.yaml

> 

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Chen-Yu Tsai <wens@csie.org>

> Cc: Thierry Reding <thierry.reding@gmail.com>

> Cc: Sam Ravnborg <sam@ravnborg.org>

> Cc: Rui Miguel Silva <rmfrfs@gmail.com>

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Robert Marko <robert.marko@sartura.hr>

> Cc: Philipp Zabel <p.zabel@pengutronix.de>

> Cc: Alessandro Zummo <a.zummo@towertech.it>

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>

> Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Oleksij Rempel <o.rempel@pengutronix.de>

> Cc: ChiYuan Huang <cy_huang@richtek.com>

> Cc: Wei Xu <xuwei5@hisilicon.com>

> Cc: Dilip Kota <eswara.kota@linux.intel.com>

> Cc: Karol Gugala <kgugala@antmicro.com>

> Cc: Mateusz Holenko <mholenko@antmicro.com>

> Cc: Olivier Moysan <olivier.moysan@st.com>

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: dri-devel@lists.freedesktop.org

> Cc: linux-media@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-rtc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  .../display/allwinner,sun8i-a83t-dw-hdmi.yaml |  2 --

>  .../display/panel/boe,tv101wum-nl6.yaml       |  1 -


>  .../bindings/media/nxp,imx7-mipi-csi2.yaml    |  2 --

>  .../bindings/media/renesas,drif.yaml          |  1 -


Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> # For media



Thanks,
Mauro
Sam Ravnborg July 20, 2021, 5:56 p.m. UTC | #2
Hi Rob,

On Tue, Jul 20, 2021 at 11:20:25AM -0600, Rob Herring wrote:
> There's no reason to have "status" properties in examples. "okay" is the

> default, and "disabled" turns off some schema checks ('required'

> specifically).

> 

> Enabling qca,ar71xx causes a warning, so let's fix the node names:

> 

> Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property

>         From schema: schemas/phy/phy-provider.yaml


I had preferred that the names was fixed in a dedicated patch - to avoid
mixing things.

But thats just nitpicking, so:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Laurent Pinchart July 20, 2021, 5:58 p.m. UTC | #3
Hi Rob,

Thank you for the patch.

On Tue, Jul 20, 2021 at 11:20:25AM -0600, Rob Herring wrote:
> There's no reason to have "status" properties in examples. "okay" is the

> default, and "disabled" turns off some schema checks ('required'

> specifically).

> 

> Enabling qca,ar71xx causes a warning, so let's fix the node names:

> 

> Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property

>         From schema: schemas/phy/phy-provider.yaml

> 

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Chen-Yu Tsai <wens@csie.org>

> Cc: Thierry Reding <thierry.reding@gmail.com>

> Cc: Sam Ravnborg <sam@ravnborg.org>

> Cc: Rui Miguel Silva <rmfrfs@gmail.com>

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Robert Marko <robert.marko@sartura.hr>

> Cc: Philipp Zabel <p.zabel@pengutronix.de>

> Cc: Alessandro Zummo <a.zummo@towertech.it>

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>

> Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Oleksij Rempel <o.rempel@pengutronix.de>

> Cc: ChiYuan Huang <cy_huang@richtek.com>

> Cc: Wei Xu <xuwei5@hisilicon.com>

> Cc: Dilip Kota <eswara.kota@linux.intel.com>

> Cc: Karol Gugala <kgugala@antmicro.com>

> Cc: Mateusz Holenko <mholenko@antmicro.com>

> Cc: Olivier Moysan <olivier.moysan@st.com>

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: dri-devel@lists.freedesktop.org

> Cc: linux-media@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-rtc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  .../display/allwinner,sun8i-a83t-dw-hdmi.yaml |  2 --

>  .../display/panel/boe,tv101wum-nl6.yaml       |  1 -

>  .../bindings/media/nxp,imx7-mipi-csi2.yaml    |  2 --

>  .../bindings/media/renesas,drif.yaml          |  1 -

>  .../bindings/net/intel,dwmac-plat.yaml        |  2 --

>  .../bindings/net/intel,ixp4xx-ethernet.yaml   |  2 --

>  .../bindings/net/nfc/samsung,s3fwrn5.yaml     |  3 ---

>  .../devicetree/bindings/net/qca,ar71xx.yaml   | 25 ++++---------------

>  .../regulator/richtek,rt6245-regulator.yaml   |  1 -

>  .../regulator/vqmmc-ipq4019-regulator.yaml    |  1 -

>  .../reset/hisilicon,hi3660-reset.yaml         |  1 -

>  .../bindings/reset/intel,rcu-gw.yaml          |  1 -

>  .../bindings/rtc/microcrystal,rv3032.yaml     |  1 -

>  .../soc/litex/litex,soc-controller.yaml       |  1 -

>  .../bindings/sound/st,stm32-sai.yaml          |  2 --

>  .../bindings/sound/ti,j721e-cpb-audio.yaml    |  2 --

>  .../sound/ti,j721e-cpb-ivi-audio.yaml         |  2 --

>  17 files changed, 5 insertions(+), 45 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml

> index 5d42d36608d9..4951b5ef5c6a 100644

> --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml

> +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml

> @@ -174,7 +174,6 @@ examples:

>          phy-names = "phy";

>          pinctrl-names = "default";

>          pinctrl-0 = <&hdmi_pins>;

> -        status = "disabled";

>  

>          ports {

>              #address-cells = <1>;

> @@ -233,7 +232,6 @@ examples:

>          phy-names = "phy";

>          pinctrl-names = "default";

>          pinctrl-0 = <&hdmi_pins>;

> -        status = "disabled";

>  

>          ports {

>              #address-cells = <1>;

> diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml

> index 38bc1d1b511e..b87a2e28c866 100644

> --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml

> +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml

> @@ -70,7 +70,6 @@ examples:

>              avee-supply = <&ppvarp_lcd>;

>              pp1800-supply = <&pp1800_lcd>;

>              backlight = <&backlight_lcd0>;

> -            status = "okay";

>              port {

>                  panel_in: endpoint {

>                      remote-endpoint = <&dsi_out>;

> diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> index 7c09eec78ce5..877183cf4278 100644

> --- a/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> +++ b/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> @@ -200,8 +200,6 @@ examples:

>          clock-names = "pclk", "wrap", "phy", "axi";

>          power-domains = <&mipi_pd>;

>  

> -        status = "disabled";

> -

>          ports {

>              #address-cells = <1>;

>              #size-cells = <0>;

> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml

> index 2867d11fe156..9403b235e976 100644

> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml

> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml

> @@ -242,7 +242,6 @@ examples:

>                      power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;

>                      resets = <&cpg 513>;

>                      renesas,bonding = <&drif11>;

> -                    status = "disabled";

>              };

>  

>              drif11: rif@e6f70000 {

> diff --git a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml

> index c1948ce00081..79fa04f5e40d 100644

> --- a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml

> +++ b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml

> @@ -116,8 +116,6 @@ examples:

>          snps,mtl-rx-config = <&mtl_rx_setup>;

>          snps,mtl-tx-config = <&mtl_tx_setup>;

>          snps,tso;

> -        status = "okay";

> -


I would have kept the blank line here.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


>          mdio0 {

>              #address-cells = <1>;

>              #size-cells = <0>;

> diff --git a/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml b/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml

> index f2e91d1bf7d7..378ed2d3b003 100644

> --- a/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml

> +++ b/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml

> @@ -71,7 +71,6 @@ examples:

>      ethernet@c8009000 {

>        compatible = "intel,ixp4xx-ethernet";

>        reg = <0xc8009000 0x1000>;

> -      status = "disabled";

>        queue-rx = <&qmgr 4>;

>        queue-txready = <&qmgr 21>;

>        intel,npe-handle = <&npe 1>;

> @@ -82,7 +81,6 @@ examples:

>      ethernet@c800c000 {

>        compatible = "intel,ixp4xx-ethernet";

>        reg = <0xc800c000 0x1000>;

> -      status = "disabled";

>        queue-rx = <&qmgr 3>;

>        queue-txready = <&qmgr 20>;

>        intel,npe-handle = <&npe 2>;

> diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml

> index 081742c2b726..64995cbb0f97 100644

> --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml

> +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml

> @@ -90,14 +90,11 @@ examples:

>    # UART example on Raspberry Pi

>    - |

>      uart0 {

> -        status = "okay";

> -

>          nfc {

>              compatible = "samsung,s3fwrn82";

>  

>              en-gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;

>              wake-gpios = <&gpio 16 GPIO_ACTIVE_HIGH>;

>  

> -            status = "okay";

>          };

>      };

> diff --git a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml b/Documentation/devicetree/bindings/net/qca,ar71xx.yaml

> index f0db22645d73..cf4d35edaa1b 100644

> --- a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml

> +++ b/Documentation/devicetree/bindings/net/qca,ar71xx.yaml

> @@ -101,8 +101,6 @@ examples:

>  

>          phy-mode = "gmii";

>  

> -        status = "disabled";

> -

>          fixed-link {

>              speed = <1000>;

>              full-duplex;

> @@ -148,32 +146,24 @@ examples:

>                          reg = <0x1>;

>                          phy-handle = <&phy_port0>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>  

>                      switch_port2: port@2 {

>                          reg = <0x2>;

>                          phy-handle = <&phy_port1>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>  

>                      switch_port3: port@3 {

>                          reg = <0x3>;

>                          phy-handle = <&phy_port2>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>  

>                      switch_port4: port@4 {

>                          reg = <0x4>;

>                          phy-handle = <&phy_port3>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>                  };

>  

> @@ -183,34 +173,29 @@ examples:

>  

>                      interrupt-parent = <&switch10>;

>  

> -                    phy_port0: phy@0 {

> +                    phy_port0: ethernet-phy@0 {

>                          reg = <0x0>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port1: phy@1 {

> +                    phy_port1: ethernet-phy@1 {

>                          reg = <0x1>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port2: phy@2 {

> +                    phy_port2: ethernet-phy@2 {

>                          reg = <0x2>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port3: phy@3 {

> +                    phy_port3: ethernet-phy@3 {

>                          reg = <0x3>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port4: phy@4 {

> +                    phy_port4: ethernet-phy@4 {

>                          reg = <0x4>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>                  };

>              };

> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml

> index 796ceac87445..e983d0e70c9b 100644

> --- a/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml

> +++ b/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml

> @@ -77,7 +77,6 @@ examples:

>  

>        rt6245@34 {

>          compatible = "richtek,rt6245";

> -        status = "okay";

>          reg = <0x34>;

>          enable-gpios = <&gpio26 2 0>;

>  

> diff --git a/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml b/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml

> index 6f45582c914e..dd7a2f92634c 100644

> --- a/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml

> +++ b/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml

> @@ -39,6 +39,5 @@ examples:

>        regulator-min-microvolt = <1500000>;

>        regulator-max-microvolt = <3000000>;

>        regulator-always-on;

> -      status = "disabled";

>      };

>  ...

> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml

> index 9bf40952e5b7..b0c41ab1a746 100644

> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml

> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml

> @@ -72,6 +72,5 @@ examples:

>          resets = <&iomcu_rst 0x20 3>;

>          pinctrl-names = "default";

>          pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;

> -        status = "disabled";

>      };

>  ...

> diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml

> index 6b2d56cc3f38..13bf6bb3f097 100644

> --- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml

> +++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml

> @@ -57,7 +57,6 @@ examples:

>      };

>  

>      pwm: pwm@e0d00000 {

> -        status = "disabled";

>          compatible = "intel,lgm-pwm";

>          reg = <0xe0d00000 0x30>;

>          clocks = <&cgu0 1>;

> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml

> index a2c55303810d..9593840a4a2b 100644

> --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml

> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml

> @@ -53,7 +53,6 @@ examples:

>          rtc@51 {

>              compatible = "microcrystal,rv3032";

>              reg = <0x51>;

> -            status = "okay";

>              pinctrl-0 = <&rtc_nint_pins>;

>              interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;

>              trickle-resistor-ohms = <7000>;

> diff --git a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

> index c8b57c7fd08c..ecae9fa8561b 100644

> --- a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

> +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

> @@ -35,7 +35,6 @@ examples:

>      soc_ctrl0: soc-controller@f0000000 {

>          compatible = "litex,soc-controller";

>          reg = <0xf0000000 0xc>;

> -        status = "okay";

>      };

>  

>  ...

> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml

> index 06e83461705c..f97132400bb6 100644

> --- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml

> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml

> @@ -180,7 +180,6 @@ examples:

>        pinctrl-names = "default", "sleep";

>        pinctrl-0 = <&sai2a_pins_a>, <&sai2b_pins_b>;

>        pinctrl-1 = <&sai2a_sleep_pins_a>, <&sai2b_sleep_pins_b>;

> -      status = "okay";

>  

>        sai2a: audio-controller@4400b004 {

>          #sound-dai-cells = <0>;

> @@ -190,7 +189,6 @@ examples:

>          dma-names = "tx";

>          clocks = <&rcc SAI2_K>;

>          clock-names = "sai_ck";

> -        status = "okay";

>        };

>      };

>  

> diff --git a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml

> index ec06789b21df..6806f53a4aed 100644

> --- a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml

> +++ b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml

> @@ -127,8 +127,6 @@ examples:

>          compatible = "ti,j721e-cpb-audio";

>          model = "j721e-cpb";

>  

> -        status = "okay";

> -

>          ti,cpb-mcasp = <&mcasp10>;

>          ti,cpb-codec = <&pcm3168a_1>;

>  

> diff --git a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml

> index ee9f960de36b..859d369c71e2 100644

> --- a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml

> +++ b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml

> @@ -119,8 +119,6 @@ examples:

>          compatible = "ti,j721e-cpb-ivi-audio";

>          model = "j721e-cpb-ivi";

>  

> -        status = "okay";

> -

>          ti,cpb-mcasp = <&mcasp10>;

>          ti,cpb-codec = <&pcm3168a_1>;

>  


-- 
Regards,

Laurent Pinchart
Mark Brown July 20, 2021, 8:33 p.m. UTC | #4
On Tue, Jul 20, 2021 at 11:20:25AM -0600, Rob Herring wrote:
> There's no reason to have "status" properties in examples. "okay" is the

> default, and "disabled" turns off some schema checks ('required'

> specifically).


Acked-by: Mark Brown <broonie@kernel.org>
Philipp Zabel July 21, 2021, 8:32 a.m. UTC | #5
Hi Rob,

On Tue, 2021-07-20 at 11:20 -0600, Rob Herring wrote:
> There's no reason to have "status" properties in examples. "okay" is the

> default, and "disabled" turns off some schema checks ('required'

> specifically).


Is this documented somewhere? If not, should it be? (Maybe in writing-
schema.rst -> Schema Contents -> examples?)
 
> Enabling qca,ar71xx causes a warning, so let's fix the node names:

> 

> Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property

>         From schema: schemas/phy/phy-provider.yaml

> 

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Chen-Yu Tsai <wens@csie.org>

> Cc: Thierry Reding <thierry.reding@gmail.com>

> Cc: Sam Ravnborg <sam@ravnborg.org>

> Cc: Rui Miguel Silva <rmfrfs@gmail.com>

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Robert Marko <robert.marko@sartura.hr>

> Cc: Philipp Zabel <p.zabel@pengutronix.de>

> Cc: Alessandro Zummo <a.zummo@towertech.it>

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>

> Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Oleksij Rempel <o.rempel@pengutronix.de>

> Cc: ChiYuan Huang <cy_huang@richtek.com>

> Cc: Wei Xu <xuwei5@hisilicon.com>

> Cc: Dilip Kota <eswara.kota@linux.intel.com>

> Cc: Karol Gugala <kgugala@antmicro.com>

> Cc: Mateusz Holenko <mholenko@antmicro.com>

> Cc: Olivier Moysan <olivier.moysan@st.com>

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: dri-devel@lists.freedesktop.org

> Cc: linux-media@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-rtc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  .../display/allwinner,sun8i-a83t-dw-hdmi.yaml |  2 --

>  .../display/panel/boe,tv101wum-nl6.yaml       |  1 -

>  .../bindings/media/nxp,imx7-mipi-csi2.yaml    |  2 --

>  .../bindings/media/renesas,drif.yaml          |  1 -

>  .../bindings/net/intel,dwmac-plat.yaml        |  2 --

>  .../bindings/net/intel,ixp4xx-ethernet.yaml   |  2 --

>  .../bindings/net/nfc/samsung,s3fwrn5.yaml     |  3 ---

>  .../devicetree/bindings/net/qca,ar71xx.yaml   | 25 ++++---------------

>  .../regulator/richtek,rt6245-regulator.yaml   |  1 -

>  .../regulator/vqmmc-ipq4019-regulator.yaml    |  1 -

>  .../reset/hisilicon,hi3660-reset.yaml         |  1 -

>  .../bindings/reset/intel,rcu-gw.yaml          |  1 -

[...]

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>


regards
Philipp
Oleksij Rempel July 21, 2021, 11:05 a.m. UTC | #6
On Tue, Jul 20, 2021 at 11:20:25AM -0600, Rob Herring wrote:
> There's no reason to have "status" properties in examples. "okay" is the

> default, and "disabled" turns off some schema checks ('required'

> specifically).

> 

> Enabling qca,ar71xx causes a warning, so let's fix the node names:

> 

> Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property

>         From schema: schemas/phy/phy-provider.yaml

> 

> Cc: Maxime Ripard <mripard@kernel.org>

> Cc: Chen-Yu Tsai <wens@csie.org>

> Cc: Thierry Reding <thierry.reding@gmail.com>

> Cc: Sam Ravnborg <sam@ravnborg.org>

> Cc: Rui Miguel Silva <rmfrfs@gmail.com>

> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: Jakub Kicinski <kuba@kernel.org>

> Cc: Mark Brown <broonie@kernel.org>

> Cc: Robert Marko <robert.marko@sartura.hr>

> Cc: Philipp Zabel <p.zabel@pengutronix.de>

> Cc: Alessandro Zummo <a.zummo@towertech.it>

> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com>

> Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>

> Cc: Linus Walleij <linus.walleij@linaro.org>

> Cc: Oleksij Rempel <o.rempel@pengutronix.de>

> Cc: ChiYuan Huang <cy_huang@richtek.com>

> Cc: Wei Xu <xuwei5@hisilicon.com>

> Cc: Dilip Kota <eswara.kota@linux.intel.com>

> Cc: Karol Gugala <kgugala@antmicro.com>

> Cc: Mateusz Holenko <mholenko@antmicro.com>

> Cc: Olivier Moysan <olivier.moysan@st.com>

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: dri-devel@lists.freedesktop.org

> Cc: linux-media@vger.kernel.org

> Cc: netdev@vger.kernel.org

> Cc: linux-rtc@vger.kernel.org

> Cc: alsa-devel@alsa-project.org

> Signed-off-by: Rob Herring <robh@kernel.org>



Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>


> ---

>  .../display/allwinner,sun8i-a83t-dw-hdmi.yaml |  2 --

>  .../display/panel/boe,tv101wum-nl6.yaml       |  1 -

>  .../bindings/media/nxp,imx7-mipi-csi2.yaml    |  2 --

>  .../bindings/media/renesas,drif.yaml          |  1 -

>  .../bindings/net/intel,dwmac-plat.yaml        |  2 --

>  .../bindings/net/intel,ixp4xx-ethernet.yaml   |  2 --

>  .../bindings/net/nfc/samsung,s3fwrn5.yaml     |  3 ---

>  .../devicetree/bindings/net/qca,ar71xx.yaml   | 25 ++++---------------

>  .../regulator/richtek,rt6245-regulator.yaml   |  1 -

>  .../regulator/vqmmc-ipq4019-regulator.yaml    |  1 -

>  .../reset/hisilicon,hi3660-reset.yaml         |  1 -

>  .../bindings/reset/intel,rcu-gw.yaml          |  1 -

>  .../bindings/rtc/microcrystal,rv3032.yaml     |  1 -

>  .../soc/litex/litex,soc-controller.yaml       |  1 -

>  .../bindings/sound/st,stm32-sai.yaml          |  2 --

>  .../bindings/sound/ti,j721e-cpb-audio.yaml    |  2 --

>  .../sound/ti,j721e-cpb-ivi-audio.yaml         |  2 --

>  17 files changed, 5 insertions(+), 45 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml

> index 5d42d36608d9..4951b5ef5c6a 100644

> --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml

> +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml

> @@ -174,7 +174,6 @@ examples:

>          phy-names = "phy";

>          pinctrl-names = "default";

>          pinctrl-0 = <&hdmi_pins>;

> -        status = "disabled";

>  

>          ports {

>              #address-cells = <1>;

> @@ -233,7 +232,6 @@ examples:

>          phy-names = "phy";

>          pinctrl-names = "default";

>          pinctrl-0 = <&hdmi_pins>;

> -        status = "disabled";

>  

>          ports {

>              #address-cells = <1>;

> diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml

> index 38bc1d1b511e..b87a2e28c866 100644

> --- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml

> +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml

> @@ -70,7 +70,6 @@ examples:

>              avee-supply = <&ppvarp_lcd>;

>              pp1800-supply = <&pp1800_lcd>;

>              backlight = <&backlight_lcd0>;

> -            status = "okay";

>              port {

>                  panel_in: endpoint {

>                      remote-endpoint = <&dsi_out>;

> diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> index 7c09eec78ce5..877183cf4278 100644

> --- a/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> +++ b/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> @@ -200,8 +200,6 @@ examples:

>          clock-names = "pclk", "wrap", "phy", "axi";

>          power-domains = <&mipi_pd>;

>  

> -        status = "disabled";

> -

>          ports {

>              #address-cells = <1>;

>              #size-cells = <0>;

> diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml

> index 2867d11fe156..9403b235e976 100644

> --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml

> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml

> @@ -242,7 +242,6 @@ examples:

>                      power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;

>                      resets = <&cpg 513>;

>                      renesas,bonding = <&drif11>;

> -                    status = "disabled";

>              };

>  

>              drif11: rif@e6f70000 {

> diff --git a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml

> index c1948ce00081..79fa04f5e40d 100644

> --- a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml

> +++ b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml

> @@ -116,8 +116,6 @@ examples:

>          snps,mtl-rx-config = <&mtl_rx_setup>;

>          snps,mtl-tx-config = <&mtl_tx_setup>;

>          snps,tso;

> -        status = "okay";

> -

>          mdio0 {

>              #address-cells = <1>;

>              #size-cells = <0>;

> diff --git a/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml b/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml

> index f2e91d1bf7d7..378ed2d3b003 100644

> --- a/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml

> +++ b/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml

> @@ -71,7 +71,6 @@ examples:

>      ethernet@c8009000 {

>        compatible = "intel,ixp4xx-ethernet";

>        reg = <0xc8009000 0x1000>;

> -      status = "disabled";

>        queue-rx = <&qmgr 4>;

>        queue-txready = <&qmgr 21>;

>        intel,npe-handle = <&npe 1>;

> @@ -82,7 +81,6 @@ examples:

>      ethernet@c800c000 {

>        compatible = "intel,ixp4xx-ethernet";

>        reg = <0xc800c000 0x1000>;

> -      status = "disabled";

>        queue-rx = <&qmgr 3>;

>        queue-txready = <&qmgr 20>;

>        intel,npe-handle = <&npe 2>;

> diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml

> index 081742c2b726..64995cbb0f97 100644

> --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml

> +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml

> @@ -90,14 +90,11 @@ examples:

>    # UART example on Raspberry Pi

>    - |

>      uart0 {

> -        status = "okay";

> -

>          nfc {

>              compatible = "samsung,s3fwrn82";

>  

>              en-gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;

>              wake-gpios = <&gpio 16 GPIO_ACTIVE_HIGH>;

>  

> -            status = "okay";

>          };

>      };

> diff --git a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml b/Documentation/devicetree/bindings/net/qca,ar71xx.yaml

> index f0db22645d73..cf4d35edaa1b 100644

> --- a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml

> +++ b/Documentation/devicetree/bindings/net/qca,ar71xx.yaml

> @@ -101,8 +101,6 @@ examples:

>  

>          phy-mode = "gmii";

>  

> -        status = "disabled";

> -

>          fixed-link {

>              speed = <1000>;

>              full-duplex;

> @@ -148,32 +146,24 @@ examples:

>                          reg = <0x1>;

>                          phy-handle = <&phy_port0>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>  

>                      switch_port2: port@2 {

>                          reg = <0x2>;

>                          phy-handle = <&phy_port1>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>  

>                      switch_port3: port@3 {

>                          reg = <0x3>;

>                          phy-handle = <&phy_port2>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>  

>                      switch_port4: port@4 {

>                          reg = <0x4>;

>                          phy-handle = <&phy_port3>;

>                          phy-mode = "internal";

> -

> -                        status = "disabled";

>                      };

>                  };

>  

> @@ -183,34 +173,29 @@ examples:

>  

>                      interrupt-parent = <&switch10>;

>  

> -                    phy_port0: phy@0 {

> +                    phy_port0: ethernet-phy@0 {

>                          reg = <0x0>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port1: phy@1 {

> +                    phy_port1: ethernet-phy@1 {

>                          reg = <0x1>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port2: phy@2 {

> +                    phy_port2: ethernet-phy@2 {

>                          reg = <0x2>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port3: phy@3 {

> +                    phy_port3: ethernet-phy@3 {

>                          reg = <0x3>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>  

> -                    phy_port4: phy@4 {

> +                    phy_port4: ethernet-phy@4 {

>                          reg = <0x4>;

>                          interrupts = <0>;

> -                        status = "disabled";

>                      };

>                  };

>              };

> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml

> index 796ceac87445..e983d0e70c9b 100644

> --- a/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml

> +++ b/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml

> @@ -77,7 +77,6 @@ examples:

>  

>        rt6245@34 {

>          compatible = "richtek,rt6245";

> -        status = "okay";

>          reg = <0x34>;

>          enable-gpios = <&gpio26 2 0>;

>  

> diff --git a/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml b/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml

> index 6f45582c914e..dd7a2f92634c 100644

> --- a/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml

> +++ b/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml

> @@ -39,6 +39,5 @@ examples:

>        regulator-min-microvolt = <1500000>;

>        regulator-max-microvolt = <3000000>;

>        regulator-always-on;

> -      status = "disabled";

>      };

>  ...

> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml

> index 9bf40952e5b7..b0c41ab1a746 100644

> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml

> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml

> @@ -72,6 +72,5 @@ examples:

>          resets = <&iomcu_rst 0x20 3>;

>          pinctrl-names = "default";

>          pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;

> -        status = "disabled";

>      };

>  ...

> diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml

> index 6b2d56cc3f38..13bf6bb3f097 100644

> --- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml

> +++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml

> @@ -57,7 +57,6 @@ examples:

>      };

>  

>      pwm: pwm@e0d00000 {

> -        status = "disabled";

>          compatible = "intel,lgm-pwm";

>          reg = <0xe0d00000 0x30>;

>          clocks = <&cgu0 1>;

> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml

> index a2c55303810d..9593840a4a2b 100644

> --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml

> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml

> @@ -53,7 +53,6 @@ examples:

>          rtc@51 {

>              compatible = "microcrystal,rv3032";

>              reg = <0x51>;

> -            status = "okay";

>              pinctrl-0 = <&rtc_nint_pins>;

>              interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;

>              trickle-resistor-ohms = <7000>;

> diff --git a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

> index c8b57c7fd08c..ecae9fa8561b 100644

> --- a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

> +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

> @@ -35,7 +35,6 @@ examples:

>      soc_ctrl0: soc-controller@f0000000 {

>          compatible = "litex,soc-controller";

>          reg = <0xf0000000 0xc>;

> -        status = "okay";

>      };

>  

>  ...

> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml

> index 06e83461705c..f97132400bb6 100644

> --- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml

> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml

> @@ -180,7 +180,6 @@ examples:

>        pinctrl-names = "default", "sleep";

>        pinctrl-0 = <&sai2a_pins_a>, <&sai2b_pins_b>;

>        pinctrl-1 = <&sai2a_sleep_pins_a>, <&sai2b_sleep_pins_b>;

> -      status = "okay";

>  

>        sai2a: audio-controller@4400b004 {

>          #sound-dai-cells = <0>;

> @@ -190,7 +189,6 @@ examples:

>          dma-names = "tx";

>          clocks = <&rcc SAI2_K>;

>          clock-names = "sai_ck";

> -        status = "okay";

>        };

>      };

>  

> diff --git a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml

> index ec06789b21df..6806f53a4aed 100644

> --- a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml

> +++ b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml

> @@ -127,8 +127,6 @@ examples:

>          compatible = "ti,j721e-cpb-audio";

>          model = "j721e-cpb";

>  

> -        status = "okay";

> -

>          ti,cpb-mcasp = <&mcasp10>;

>          ti,cpb-codec = <&pcm3168a_1>;

>  

> diff --git a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml

> index ee9f960de36b..859d369c71e2 100644

> --- a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml

> +++ b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml

> @@ -119,8 +119,6 @@ examples:

>          compatible = "ti,j721e-cpb-ivi-audio";

>          model = "j721e-cpb-ivi";

>  

> -        status = "okay";

> -

>          ti,cpb-mcasp = <&mcasp10>;

>          ti,cpb-codec = <&pcm3168a_1>;

>  

> -- 

> 2.27.0

> 

> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Rob Herring (Arm) July 21, 2021, 1:49 p.m. UTC | #7
On Wed, Jul 21, 2021 at 2:33 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>

> Hi Rob,

>

> On Tue, 2021-07-20 at 11:20 -0600, Rob Herring wrote:

> > There's no reason to have "status" properties in examples. "okay" is the

> > default, and "disabled" turns off some schema checks ('required'

> > specifically).

>

> Is this documented somewhere? If not, should it be? (Maybe in writing-

> schema.rst -> Schema Contents -> examples?)


I don't think it is. I'm writing a schema for it which works for both
those that read documentation and those that don't.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml
index 5d42d36608d9..4951b5ef5c6a 100644
--- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml
@@ -174,7 +174,6 @@  examples:
         phy-names = "phy";
         pinctrl-names = "default";
         pinctrl-0 = <&hdmi_pins>;
-        status = "disabled";
 
         ports {
             #address-cells = <1>;
@@ -233,7 +232,6 @@  examples:
         phy-names = "phy";
         pinctrl-names = "default";
         pinctrl-0 = <&hdmi_pins>;
-        status = "disabled";
 
         ports {
             #address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
index 38bc1d1b511e..b87a2e28c866 100644
--- a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
+++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
@@ -70,7 +70,6 @@  examples:
             avee-supply = <&ppvarp_lcd>;
             pp1800-supply = <&pp1800_lcd>;
             backlight = <&backlight_lcd0>;
-            status = "okay";
             port {
                 panel_in: endpoint {
                     remote-endpoint = <&dsi_out>;
diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
index 7c09eec78ce5..877183cf4278 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
@@ -200,8 +200,6 @@  examples:
         clock-names = "pclk", "wrap", "phy", "axi";
         power-domains = <&mipi_pd>;
 
-        status = "disabled";
-
         ports {
             #address-cells = <1>;
             #size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index 2867d11fe156..9403b235e976 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -242,7 +242,6 @@  examples:
                     power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
                     resets = <&cpg 513>;
                     renesas,bonding = <&drif11>;
-                    status = "disabled";
             };
 
             drif11: rif@e6f70000 {
diff --git a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
index c1948ce00081..79fa04f5e40d 100644
--- a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
+++ b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
@@ -116,8 +116,6 @@  examples:
         snps,mtl-rx-config = <&mtl_rx_setup>;
         snps,mtl-tx-config = <&mtl_tx_setup>;
         snps,tso;
-        status = "okay";
-
         mdio0 {
             #address-cells = <1>;
             #size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml b/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml
index f2e91d1bf7d7..378ed2d3b003 100644
--- a/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml
+++ b/Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml
@@ -71,7 +71,6 @@  examples:
     ethernet@c8009000 {
       compatible = "intel,ixp4xx-ethernet";
       reg = <0xc8009000 0x1000>;
-      status = "disabled";
       queue-rx = <&qmgr 4>;
       queue-txready = <&qmgr 21>;
       intel,npe-handle = <&npe 1>;
@@ -82,7 +81,6 @@  examples:
     ethernet@c800c000 {
       compatible = "intel,ixp4xx-ethernet";
       reg = <0xc800c000 0x1000>;
-      status = "disabled";
       queue-rx = <&qmgr 3>;
       queue-txready = <&qmgr 20>;
       intel,npe-handle = <&npe 2>;
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
index 081742c2b726..64995cbb0f97 100644
--- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml
@@ -90,14 +90,11 @@  examples:
   # UART example on Raspberry Pi
   - |
     uart0 {
-        status = "okay";
-
         nfc {
             compatible = "samsung,s3fwrn82";
 
             en-gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
             wake-gpios = <&gpio 16 GPIO_ACTIVE_HIGH>;
 
-            status = "okay";
         };
     };
diff --git a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml b/Documentation/devicetree/bindings/net/qca,ar71xx.yaml
index f0db22645d73..cf4d35edaa1b 100644
--- a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml
+++ b/Documentation/devicetree/bindings/net/qca,ar71xx.yaml
@@ -101,8 +101,6 @@  examples:
 
         phy-mode = "gmii";
 
-        status = "disabled";
-
         fixed-link {
             speed = <1000>;
             full-duplex;
@@ -148,32 +146,24 @@  examples:
                         reg = <0x1>;
                         phy-handle = <&phy_port0>;
                         phy-mode = "internal";
-
-                        status = "disabled";
                     };
 
                     switch_port2: port@2 {
                         reg = <0x2>;
                         phy-handle = <&phy_port1>;
                         phy-mode = "internal";
-
-                        status = "disabled";
                     };
 
                     switch_port3: port@3 {
                         reg = <0x3>;
                         phy-handle = <&phy_port2>;
                         phy-mode = "internal";
-
-                        status = "disabled";
                     };
 
                     switch_port4: port@4 {
                         reg = <0x4>;
                         phy-handle = <&phy_port3>;
                         phy-mode = "internal";
-
-                        status = "disabled";
                     };
                 };
 
@@ -183,34 +173,29 @@  examples:
 
                     interrupt-parent = <&switch10>;
 
-                    phy_port0: phy@0 {
+                    phy_port0: ethernet-phy@0 {
                         reg = <0x0>;
                         interrupts = <0>;
-                        status = "disabled";
                     };
 
-                    phy_port1: phy@1 {
+                    phy_port1: ethernet-phy@1 {
                         reg = <0x1>;
                         interrupts = <0>;
-                        status = "disabled";
                     };
 
-                    phy_port2: phy@2 {
+                    phy_port2: ethernet-phy@2 {
                         reg = <0x2>;
                         interrupts = <0>;
-                        status = "disabled";
                     };
 
-                    phy_port3: phy@3 {
+                    phy_port3: ethernet-phy@3 {
                         reg = <0x3>;
                         interrupts = <0>;
-                        status = "disabled";
                     };
 
-                    phy_port4: phy@4 {
+                    phy_port4: ethernet-phy@4 {
                         reg = <0x4>;
                         interrupts = <0>;
-                        status = "disabled";
                     };
                 };
             };
diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml
index 796ceac87445..e983d0e70c9b 100644
--- a/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/richtek,rt6245-regulator.yaml
@@ -77,7 +77,6 @@  examples:
 
       rt6245@34 {
         compatible = "richtek,rt6245";
-        status = "okay";
         reg = <0x34>;
         enable-gpios = <&gpio26 2 0>;
 
diff --git a/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml b/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml
index 6f45582c914e..dd7a2f92634c 100644
--- a/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/vqmmc-ipq4019-regulator.yaml
@@ -39,6 +39,5 @@  examples:
       regulator-min-microvolt = <1500000>;
       regulator-max-microvolt = <3000000>;
       regulator-always-on;
-      status = "disabled";
     };
 ...
diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
index 9bf40952e5b7..b0c41ab1a746 100644
--- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.yaml
@@ -72,6 +72,5 @@  examples:
         resets = <&iomcu_rst 0x20 3>;
         pinctrl-names = "default";
         pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
-        status = "disabled";
     };
 ...
diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
index 6b2d56cc3f38..13bf6bb3f097 100644
--- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
+++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml
@@ -57,7 +57,6 @@  examples:
     };
 
     pwm: pwm@e0d00000 {
-        status = "disabled";
         compatible = "intel,lgm-pwm";
         reg = <0xe0d00000 0x30>;
         clocks = <&cgu0 1>;
diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml
index a2c55303810d..9593840a4a2b 100644
--- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml
+++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3032.yaml
@@ -53,7 +53,6 @@  examples:
         rtc@51 {
             compatible = "microcrystal,rv3032";
             reg = <0x51>;
-            status = "okay";
             pinctrl-0 = <&rtc_nint_pins>;
             interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
             trickle-resistor-ohms = <7000>;
diff --git a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
index c8b57c7fd08c..ecae9fa8561b 100644
--- a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml
@@ -35,7 +35,6 @@  examples:
     soc_ctrl0: soc-controller@f0000000 {
         compatible = "litex,soc-controller";
         reg = <0xf0000000 0xc>;
-        status = "okay";
     };
 
 ...
diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
index 06e83461705c..f97132400bb6 100644
--- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
+++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
@@ -180,7 +180,6 @@  examples:
       pinctrl-names = "default", "sleep";
       pinctrl-0 = <&sai2a_pins_a>, <&sai2b_pins_b>;
       pinctrl-1 = <&sai2a_sleep_pins_a>, <&sai2b_sleep_pins_b>;
-      status = "okay";
 
       sai2a: audio-controller@4400b004 {
         #sound-dai-cells = <0>;
@@ -190,7 +189,6 @@  examples:
         dma-names = "tx";
         clocks = <&rcc SAI2_K>;
         clock-names = "sai_ck";
-        status = "okay";
       };
     };
 
diff --git a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml
index ec06789b21df..6806f53a4aed 100644
--- a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-audio.yaml
@@ -127,8 +127,6 @@  examples:
         compatible = "ti,j721e-cpb-audio";
         model = "j721e-cpb";
 
-        status = "okay";
-
         ti,cpb-mcasp = <&mcasp10>;
         ti,cpb-codec = <&pcm3168a_1>;
 
diff --git a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml
index ee9f960de36b..859d369c71e2 100644
--- a/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,j721e-cpb-ivi-audio.yaml
@@ -119,8 +119,6 @@  examples:
         compatible = "ti,j721e-cpb-ivi-audio";
         model = "j721e-cpb-ivi";
 
-        status = "okay";
-
         ti,cpb-mcasp = <&mcasp10>;
         ti,cpb-codec = <&pcm3168a_1>;