diff mbox series

[BlueZ] monitor: Print EIR of Extended Advertisement Report

Message ID 20210715003521.2222-1-sonnysasaka@chromium.org
State New
Headers show
Series [BlueZ] monitor: Print EIR of Extended Advertisement Report | expand

Commit Message

Sonny Sasaka July 15, 2021, 12:35 a.m. UTC 
It's useful to be able to see Extended Adv's EIR flags just like the
legacy Adv.

Change-Id: I4805e589837733e7ecf9d33218e4135e8f822a7c
---
 monitor/packet.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Sonny Sasaka July 29, 2021, 5:51 p.m. UTC | #1 
Dear Maintainers,

Friendly ping to review this simple patch. Thanks!


On Wed, Jul 14, 2021 at 6:26 PM <bluez.test.bot@gmail.com> wrote:
>

> This is automated email and please do not reply to this email!

>

> Dear submitter,

>

> Thank you for submitting the patches to the linux bluetooth mailing list.

> This is a CI test results with your patch series:

> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=515781

>

> ---Test result---

>

> Test Summary:

> CheckPatch                    FAIL      0.24 seconds

> GitLint                       PASS      0.11 seconds

> Prep - Setup ELL              PASS      39.40 seconds

> Build - Prep                  PASS      0.09 seconds

> Build - Configure             PASS      7.11 seconds

> Build - Make                  PASS      170.91 seconds

> Make Check                    PASS      8.82 seconds

> Make Distcheck                PASS      204.00 seconds

> Build w/ext ELL - Configure   PASS      6.98 seconds

> Build w/ext ELL - Make        PASS      161.16 seconds

>

> Details

> ##############################

> Test: CheckPatch - FAIL

> Desc: Run checkpatch.pl script with rule in .checkpatch.conf

> Output:

> monitor: Print EIR of Extended Advertisement Report

> ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting upstream

> #9:

> Change-Id: I4805e589837733e7ecf9d33218e4135e8f822a7c

>

> - total: 1 errors, 0 warnings, 7 lines checked

>

> NOTE: For some of the reported defects, checkpatch may be able to

>       mechanically convert to the typical style using --fix or --fix-inplace.

>

> "[PATCH] monitor: Print EIR of Extended Advertisement Report" has style problems, please review.

>

> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

>

> NOTE: If any of the errors are false positives, please report

>       them to the maintainer, see CHECKPATCH in MAINTAINERS.

>

>

> ##############################

> Test: GitLint - PASS

> Desc: Run gitlint with rule in .gitlint

>

> ##############################

> Test: Prep - Setup ELL - PASS

> Desc: Clone, build, and install ELL

>

> ##############################

> Test: Build - Prep - PASS

> Desc: Prepare environment for build

>

> ##############################

> Test: Build - Configure - PASS

> Desc: Configure the BlueZ source tree

>

> ##############################

> Test: Build - Make - PASS

> Desc: Build the BlueZ source tree

>

> ##############################

> Test: Make Check - PASS

> Desc: Run 'make check'

>

> ##############################

> Test: Make Distcheck - PASS

> Desc: Run distcheck to check the distribution

>

> ##############################

> Test: Build w/ext ELL - Configure - PASS

> Desc: Configure BlueZ source with '--enable-external-ell' configuration

>

> ##############################

> Test: Build w/ext ELL - Make - PASS

> Desc: Build BlueZ source with '--enable-external-ell' configuration

>

>

>

> ---

> Regards,

> Linux Bluetooth

>
Luiz Augusto von Dentz July 29, 2021, 9:21 p.m. UTC | #2 
Hi Sonny,

On Thu, Jul 29, 2021 at 10:53 AM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
>

> Dear Maintainers,

>

> Friendly ping to review this simple patch. Thanks!

>

>

> On Wed, Jul 14, 2021 at 6:26 PM <bluez.test.bot@gmail.com> wrote:

> >

> > This is automated email and please do not reply to this email!

> >

> > Dear submitter,

> >

> > Thank you for submitting the patches to the linux bluetooth mailing list.

> > This is a CI test results with your patch series:

> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=515781

> >

> > ---Test result---

> >

> > Test Summary:

> > CheckPatch                    FAIL      0.24 seconds

> > GitLint                       PASS      0.11 seconds

> > Prep - Setup ELL              PASS      39.40 seconds

> > Build - Prep                  PASS      0.09 seconds

> > Build - Configure             PASS      7.11 seconds

> > Build - Make                  PASS      170.91 seconds

> > Make Check                    PASS      8.82 seconds

> > Make Distcheck                PASS      204.00 seconds

> > Build w/ext ELL - Configure   PASS      6.98 seconds

> > Build w/ext ELL - Make        PASS      161.16 seconds

> >

> > Details

> > ##############################

> > Test: CheckPatch - FAIL

> > Desc: Run checkpatch.pl script with rule in .checkpatch.conf

> > Output:

> > monitor: Print EIR of Extended Advertisement Report

> > ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting upstream

> > #9:

> > Change-Id: I4805e589837733e7ecf9d33218e4135e8f822a7c

> >

> > - total: 1 errors, 0 warnings, 7 lines checked

> >

> > NOTE: For some of the reported defects, checkpatch may be able to

> >       mechanically convert to the typical style using --fix or --fix-inplace.

> >

> > "[PATCH] monitor: Print EIR of Extended Advertisement Report" has style problems, please review.

> >

> > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

> >

> > NOTE: If any of the errors are false positives, please report

> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.

> >

> >

> > ##############################

> > Test: GitLint - PASS

> > Desc: Run gitlint with rule in .gitlint

> >

> > ##############################

> > Test: Prep - Setup ELL - PASS

> > Desc: Clone, build, and install ELL

> >

> > ##############################

> > Test: Build - Prep - PASS

> > Desc: Prepare environment for build

> >

> > ##############################

> > Test: Build - Configure - PASS

> > Desc: Configure the BlueZ source tree

> >

> > ##############################

> > Test: Build - Make - PASS

> > Desc: Build the BlueZ source tree

> >

> > ##############################

> > Test: Make Check - PASS

> > Desc: Run 'make check'

> >

> > ##############################

> > Test: Make Distcheck - PASS

> > Desc: Run distcheck to check the distribution

> >

> > ##############################

> > Test: Build w/ext ELL - Configure - PASS

> > Desc: Configure BlueZ source with '--enable-external-ell' configuration

> >

> > ##############################

> > Test: Build w/ext ELL - Make - PASS

> > Desc: Build BlueZ source with '--enable-external-ell' configuration

> >

> >

> >

> > ---

> > Regards,

> > Linux Bluetooth

> >


Pushed, thanks.

-- 
Luiz Augusto von Dentz
diff mbox series

Patch

diff --git a/monitor/packet.c b/monitor/packet.c
index fbde71101..51c0bacae 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -10602,6 +10602,7 @@  static void le_ext_adv_report_evt(const void *data, uint8_t size)
 		print_field("  Data length: 0x%2.2x", report->data_len);
 		data += sizeof(struct bt_hci_le_ext_adv_report);
 		packet_hexdump(data, report->data_len);
+		print_eir(data, report->data_len, true);
 		data += report->data_len;
 	}
 }