diff mbox series

[v3] Bluetooth: btusb: Add support for LG LGSBWAC92/TWCM-K505D

Message ID 20210712073220.200414-1-cyrozap@gmail.com
State Accepted
Commit 373568276007aa23840b142b28a469e452ecfad3
Headers show
Series [v3] Bluetooth: btusb: Add support for LG LGSBWAC92/TWCM-K505D | expand

Commit Message

Forest Crossman July 12, 2021, 7:32 a.m. UTC
The LG LGSBWAC92/TWCM-K505D/EAT64454801/EAT64454802 (it goes by many
names) is a combo WiFi/Bluetooth module that's used in several models of
LG TVs. It uses the MediaTek MT7668AUN, which is already supported in
btusb, but this device has a non-MediaTek VID:PID pair so to get it to
work we just need to add it to the list of devices to probe.

Device from /sys/kernel/debug/usb/devices:

T:  Bus=09 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  6 Spd=480  MxCh= 0
D:  Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=043e ProdID=3109 Rev= 1.00
S:  Manufacturer=MediaTek Inc.
S:  Product=Wireless_Device
S:  SerialNumber=000000000
C:* #Ifs= 3 Cfg#= 1 Atr=a0 MxPwr=100mA
A:  FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=125us
E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms
I:  If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  63 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  63 Ivl=1ms
I:* If#= 2 Alt= 0 #EPs= 8 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
E:  Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

Signed-off-by: Forest Crossman <cyrozap@gmail.com>
---

Changes from v2:
 - Specify device with USB_DEVICE again, to match the other "Additional
   MediaTek Bluetooth devices".
 - Add BTUSB_WIDEBAND_SPEECH and BTUSB_VALID_LE_STATES flags to the
   driver_info, since this device would otherwise have them applied were
   it not for the non-MediaTek vendor ID.

Changes from v1:
 - Added /sys/kernel/debug/usb/devices info.
 - Specify device with USB_DEVICE_AND_INTERFACE_INFO instead of just
   USB_DEVICE.

---
 drivers/bluetooth/btusb.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

bluez.test.bot@gmail.com July 12, 2021, 9:09 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=513851

---Test result---

Test Summary:
CheckPatch                    PASS      0.69 seconds
GitLint                       PASS      0.13 seconds
BuildKernel                   PASS      677.06 seconds
TestRunner: Setup             PASS      434.70 seconds
TestRunner: l2cap-tester      PASS      3.24 seconds
TestRunner: bnep-tester       PASS      2.22 seconds
TestRunner: mgmt-tester       PASS      34.92 seconds
TestRunner: rfcomm-tester     PASS      2.49 seconds
TestRunner: sco-tester        PASS      2.39 seconds
TestRunner: smp-tester        FAIL      2.45 seconds
TestRunner: userchan-tester   PASS      2.29 seconds

Details
##############################
Test: CheckPatch - PASS - 0.69 seconds
Run checkpatch.pl script with rule in .checkpatch.conf


##############################
Test: GitLint - PASS - 0.13 seconds
Run gitlint with rule in .gitlint


##############################
Test: BuildKernel - PASS - 677.06 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 434.70 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 3.24 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 2.22 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 34.92 seconds
Run test-runner with mgmt-tester
Total: 446, Passed: 443 (99.3%), Failed: 0, Not Run: 3

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.49 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.39 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - FAIL - 2.45 seconds
Run test-runner with smp-tester
Total: 8, Passed: 7 (87.5%), Failed: 1, Not Run: 0

Failed Test Cases
SMP Client - SC Request 2                            Failed       0.028 seconds

##############################
Test: TestRunner: userchan-tester - PASS - 2.29 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth
Marcel Holtmann July 22, 2021, 2:18 p.m. UTC | #2
Hi Forest,

> The LG LGSBWAC92/TWCM-K505D/EAT64454801/EAT64454802 (it goes by many

> names) is a combo WiFi/Bluetooth module that's used in several models of

> LG TVs. It uses the MediaTek MT7668AUN, which is already supported in

> btusb, but this device has a non-MediaTek VID:PID pair so to get it to

> work we just need to add it to the list of devices to probe.

> 

> Device from /sys/kernel/debug/usb/devices:

> 

> T:  Bus=09 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  6 Spd=480  MxCh= 0

> D:  Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1

> P:  Vendor=043e ProdID=3109 Rev= 1.00

> S:  Manufacturer=MediaTek Inc.

> S:  Product=Wireless_Device

> S:  SerialNumber=000000000

> C:* #Ifs= 3 Cfg#= 1 Atr=a0 MxPwr=100mA

> A:  FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01

> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=125us

> E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms

> I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms

> I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms

> I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms

> I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms

> I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms

> I:  If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb

> E:  Ad=83(I) Atr=01(Isoc) MxPS=  63 Ivl=1ms

> E:  Ad=03(O) Atr=01(Isoc) MxPS=  63 Ivl=1ms

> I:* If#= 2 Alt= 0 #EPs= 8 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)

> E:  Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> E:  Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> 

> Signed-off-by: Forest Crossman <cyrozap@gmail.com>

> ---

> 

> Changes from v2:

> - Specify device with USB_DEVICE again, to match the other "Additional

>   MediaTek Bluetooth devices".

> - Add BTUSB_WIDEBAND_SPEECH and BTUSB_VALID_LE_STATES flags to the

>   driver_info, since this device would otherwise have them applied were

>   it not for the non-MediaTek vendor ID.

> 

> Changes from v1:

> - Added /sys/kernel/debug/usb/devices info.

> - Specify device with USB_DEVICE_AND_INTERFACE_INFO instead of just

>   USB_DEVICE.

> 

> ---

> drivers/bluetooth/btusb.c | 5 +++++

> 1 file changed, 5 insertions(+)


patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a9855a2dd561..d644e704a460 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -410,6 +410,11 @@  static const struct usb_device_id blacklist_table[] = {
 	/* Additional MediaTek MT7615E Bluetooth devices */
 	{ USB_DEVICE(0x13d3, 0x3560), .driver_info = BTUSB_MEDIATEK},
 
+	/* Additional MediaTek MT7668 Bluetooth devices */
+	{ USB_DEVICE(0x043e, 0x3109), .driver_info = BTUSB_MEDIATEK |
+						     BTUSB_WIDEBAND_SPEECH |
+						     BTUSB_VALID_LE_STATES },
+
 	/* Additional MediaTek MT7921 Bluetooth devices */
 	{ USB_DEVICE(0x04ca, 0x3802), .driver_info = BTUSB_MEDIATEK |
 						     BTUSB_WIDEBAND_SPEECH |