diff mbox series

[for,4.19] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment

Message ID 20210708091941.342219-1-nobuhiro1.iwamatsu@toshiba.co.jp
State New
Headers show
Series [for,4.19] ARM: dts: imx6qdl-sabresd: Remove incorrect power supply assignment | expand

Commit Message

Nobuhiro Iwamatsu July 8, 2021, 9:19 a.m. UTC 
From: Anson Huang <Anson.Huang@nxp.com>

commit 4521de30fbb3f5be0db58de93582ebce72c9d44f upstream.

The vdd3p0 LDO's input should be from external USB VBUS directly, NOT
PMIC's power supply, the vdd3p0 LDO's target output voltage can be
controlled by SW, and it requires input voltage to be high enough, with
incorrect power supply assigned, if the power supply's voltage is lower
than the LDO target output voltage, it will return fail and skip the LDO
voltage adjustment, so remove the power supply assignment for vdd3p0 to
avoid such scenario.

Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
 1 file changed, 4 deletions(-)

Comments

gregkh@linuxfoundation.org July 8, 2021, 6:20 p.m. UTC | #1 
On Thu, Jul 08, 2021 at 06:19:41PM +0900, Nobuhiro Iwamatsu wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
> 
> commit 4521de30fbb3f5be0db58de93582ebce72c9d44f upstream.
> 
> The vdd3p0 LDO's input should be from external USB VBUS directly, NOT
> PMIC's power supply, the vdd3p0 LDO's target output voltage can be
> controlled by SW, and it requires input voltage to be high enough, with
> incorrect power supply assigned, if the power supply's voltage is lower
> than the LDO target output voltage, it will return fail and skip the LDO
> voltage adjustment, so remove the power supply assignment for vdd3p0 to
> avoid such scenario.
> 
> Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
>  1 file changed, 4 deletions(-)

Applied, thanks.

greg k-h
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 41384bbd2f60c6..03357d39870eed 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -675,10 +675,6 @@ 
 	vin-supply = <&vgen5_reg>;
 };
 
-&reg_vdd3p0 {
-	vin-supply = <&sw2_reg>;
-};
-
 &reg_vdd2p5 {
 	vin-supply = <&vgen5_reg>;
 };