diff mbox

patch for PR65729

Message ID CAD57uCfo3DziR8zoNQmbHueqyD19dvDTofw1cybKkdDSh_fMnQ@mail.gmail.com
State New
Headers show

Commit Message

Yvan Roux April 15, 2015, 12:51 p.m. UTC 
Hi,

On 14 April 2015 at 17:36, Vladimir Makarov <vmakarov@redhat.com> wrote:
> On 04/14/2015 04:11 AM, Jakub Jelinek wrote:
>>
>> On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote:
>>>
>>> --- a/gcc/lra-constraints.c
>>> +++ b/gcc/lra-constraints.c
>>> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class
>>> rclass,
>>>   {
>>>     HARD_REG_SET temp;
>>>     -  // ??? Is this assert right
>>> -  // lra_assert (hard_reg_set_subset_p (set,
>>> reg_class_contents[rclass]));
>>> +  lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set));
>>
>> Missing space after ,
>> Otherwise, I'll defer to Vlad for review.
>>
>>
> The patch is ok for me to commit it into the trunk.  Thanks, Yvan.

The testcase needs the hard float ABI support, and can fail if tested
in a way the -march=armv7-a  is overridden.  This patch patch restrict
the test to hard vfp compliant targets.  Ok for trunk ?

Thanks,
Yvan

2015-04-15  Yvan Roux  <yvan.roux@st.com>

    * gcc.target/arm/pr65729.c: Restrict to hard float ABI compliant targets.
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/arm/pr65729.c b/gcc/testsuite/gcc.target/arm/pr65729.c
index 0d7e3c1..85383b0 100644
--- a/gcc/testsuite/gcc.target/arm/pr65729.c
+++ b/gcc/testsuite/gcc.target/arm/pr65729.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target arm_hard_vfp_ok } */
 /* { dg-options "-O2 -march=armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16" } */
 
 int foo (void)