diff mbox series

[v1,30/39] configure: stop user enabling plugins on Windows for now

Message ID 20210706145817.24109-31-alex.bennee@linaro.org
State New
Headers show
Series final pre-PR for 6.1 (testing and plugins) | expand

Commit Message

Alex Bennée July 6, 2021, 2:58 p.m. UTC 
There are some patches on the list that enable plugins on Windows but
they still need some changes to be ready:

  https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/

In the meantime lets stop the user from being able to configure the
support so they don't get confused by the weird linker error messages
later.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Cc: Yonggang Luo <luoyonggang@gmail.com>
---
 configure | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.20.1

Comments

Thomas Huth July 7, 2021, 4:24 a.m. UTC | #1 
On 06/07/2021 16.58, Alex Bennée wrote:
> There are some patches on the list that enable plugins on Windows but

> they still need some changes to be ready:

> 

>    https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/

> 

> In the meantime lets stop the user from being able to configure the

> support so they don't get confused by the weird linker error messages

> later.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> Cc: Yonggang Luo <luoyonggang@gmail.com>

> ---

>   configure | 5 +++++

>   1 file changed, 5 insertions(+)

> 

> diff --git a/configure b/configure

> index 44a487e090..9d72b31a9f 100755

> --- a/configure

> +++ b/configure

> @@ -707,6 +707,11 @@ MINGW32*)

>     else

>       audio_drv_list=""

>     fi

> +  if "$plugins" = "yes"; then

> +      error_exit "TCG plugins not currently supported on Windows platforms"

> +  else

> +      plugins="no"

> +  fi

>     supported_os="yes"

>     pie="no"

>   ;;


This also looks like the wrong spot for testing - the "--enable-plugins" 
handling is around line 1510 in the configure script, but your check has 
been added in line 707 already. Again, this has to be checked after the 
options have been parsed.

  Thomas
diff mbox series

Patch

diff --git a/configure b/configure
index 44a487e090..9d72b31a9f 100755
--- a/configure
+++ b/configure
@@ -707,6 +707,11 @@  MINGW32*)
   else
     audio_drv_list=""
   fi
+  if "$plugins" = "yes"; then
+      error_exit "TCG plugins not currently supported on Windows platforms"
+  else
+      plugins="no"
+  fi
   supported_os="yes"
   pie="no"
 ;;