diff mbox series

arm64: dts: qcom: c630: fix correct powerdown pin for WSA881x

Message ID 20210706083523.10601-1-srinivas.kandagatla@linaro.org
State Accepted
Commit 9a253bb42f190efd1a1c156939ad7298b3529dca
Headers show
Series arm64: dts: qcom: c630: fix correct powerdown pin for WSA881x | expand

Commit Message

Srinivas Kandagatla July 6, 2021, 8:35 a.m. UTC
WSA881x powerdown pin is connected to GPIO1, GPIO2 not GPIO2 and GPIO3,
so correct this. This was working so far due to a shift bug in gpio driver,
however once that is fixed this will stop working, so fix this!

For some reason we forgot to add this dts change in last merge cycle so
currently audio is broken in 5.13 as the gpio driver fix already landed
in 5.13.

Reported-by: Shawn Guo <shawnguo@kernel.org>
Fixes: 45021d35fcb2 ("arm64: dts: qcom: c630: Enable audio support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

---
 arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.21.0

Comments

Shawn Guo July 11, 2021, 7:15 a.m. UTC | #1
On Tue, Jul 06, 2021 at 09:35:23AM +0100, Srinivas Kandagatla wrote:
> WSA881x powerdown pin is connected to GPIO1, GPIO2 not GPIO2 and GPIO3,

> so correct this. This was working so far due to a shift bug in gpio driver,

> however once that is fixed this will stop working, so fix this!

> 

> For some reason we forgot to add this dts change in last merge cycle so

> currently audio is broken in 5.13 as the gpio driver fix already landed

> in 5.13.

> 

> Reported-by: Shawn Guo <shawnguo@kernel.org>

> Fixes: 45021d35fcb2 ("arm64: dts: qcom: c630: Enable audio support")

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


Tested-by: Shawn Guo <shawnguo@kernel.org>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 140db2d5ba31..cf01d3f2ed8a 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -698,7 +698,7 @@ 
 		left_spkr: wsa8810-left{
 			compatible = "sdw10217211000";
 			reg = <0 3>;
-			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
+			powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
 			#thermal-sensor-cells = <0>;
 			sound-name-prefix = "SpkrLeft";
 			#sound-dai-cells = <0>;
@@ -706,7 +706,7 @@ 
 
 		right_spkr: wsa8810-right{
 			compatible = "sdw10217211000";
-			powerdown-gpios = <&wcdgpio 3 GPIO_ACTIVE_HIGH>;
+			powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
 			reg = <0 4>;
 			#thermal-sensor-cells = <0>;
 			sound-name-prefix = "SpkrRight";