diff mbox series

bluetooth/virtio_bt: Fix dereference null return value

Message ID 20210704145504.24756-1-john.wood@gmx.com
State New
Headers show
Series bluetooth/virtio_bt: Fix dereference null return value | expand

Commit Message

John Wood July 4, 2021, 2:55 p.m. UTC 
The alloc_skb function returns NULL on error. So, test this case and
avoid a NULL dereference (skb->data).

Addresses-Coverity-ID: 1484718 ("Dereference null return value")
Fixes: afd2daa26c7ab ("Bluetooth: Add support for virtio transport driver")
Signed-off-by: John Wood <john.wood@gmx.com>
---
 drivers/bluetooth/virtio_bt.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.25.1
diff mbox series

Patch

diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
index c804db7e90f8..5f82574236c0 100644
--- a/drivers/bluetooth/virtio_bt.c
+++ b/drivers/bluetooth/virtio_bt.c
@@ -34,6 +34,8 @@  static int virtbt_add_inbuf(struct virtio_bluetooth *vbt)
 	int err;

 	skb = alloc_skb(1000, GFP_KERNEL);
+	if (!skb)
+		return -ENOMEM;
 	sg_init_one(sg, skb->data, 1000);

 	err = virtqueue_add_inbuf(vq, sg, 1, skb, GFP_KERNEL);