| Message ID | 20210624105517.3886963-2-hsinyi@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v6,RESEND,1/3] gpu: drm: separate panel orientation property creating and value setting | expand |
Hi Hsin-Yi, Thank you for your patch. Missatge de Hsin-Yi Wang <hsinyi@chromium.org> del dia dj., 24 de juny 2021 a les 12:55: > > Init panel orientation property after connector is initialized. Let the > panel driver decides the orientation value later. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> As together with the other two patches works and I don't see any problem on the Lenovo IdeaPad Duet, and the panel has the proper orientation > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd92..9da1fd6491319 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > ret = PTR_ERR(dsi->connector); > goto err_cleanup_encoder; > } > + > + ret = drm_connector_init_panel_orientation_property(dsi->connector); > + if (ret) { > + DRM_ERROR("Unable to init panel orientation\n"); > + goto err_cleanup_encoder; > + } > + > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > return 0; > -- > 2.32.0.288.g62a8d224e6-goog >
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd92..9da1fd6491319 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; } + + ret = drm_connector_init_panel_orientation_property(dsi->connector); + if (ret) { + DRM_ERROR("Unable to init panel orientation\n"); + goto err_cleanup_encoder; + } + drm_connector_attach_encoder(dsi->connector, &dsi->encoder); return 0;