| Message ID | 20210623005307.6215-1-13145886936@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | net: bridge: remove redundant return | expand |
On 6/23/21 2:53 AM, 13145886936@163.com wrote: > From: gushengxian <gushengxian@yulong.com> > > Return statements are not needed in Void function. Maybe, but this just works. I see your patch as a matter of taste. > > Signed-off-by: gushengxian <gushengxian@yulong.com> > --- > net/bridge/br_netlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c > index 8642e56059fb..b70075939721 100644 > --- a/net/bridge/br_netlink.c > +++ b/net/bridge/br_netlink.c > @@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br, > { > u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED; > > - return br_info_notify(event, br, port, filter); > + br_info_notify(event, br, port, filter); > } > > /* > @@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = { > [IFLA_BRPORT_MODE] = { .type = NLA_U8 }, > [IFLA_BRPORT_GUARD] = { .type = NLA_U8 }, > [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 }, > - [IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 }, > + [IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 }, Useless noise. > [IFLA_BRPORT_LEARNING] = { .type = NLA_U8 }, > [IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 }, > [IFLA_BRPORT_PROXYARP] = { .type = NLA_U8 }, >
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 8642e56059fb..b70075939721 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br, { u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED; - return br_info_notify(event, br, port, filter); + br_info_notify(event, br, port, filter); } /* @@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = { [IFLA_BRPORT_MODE] = { .type = NLA_U8 }, [IFLA_BRPORT_GUARD] = { .type = NLA_U8 }, [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 }, - [IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 }, + [IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 }, [IFLA_BRPORT_LEARNING] = { .type = NLA_U8 }, [IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 }, [IFLA_BRPORT_PROXYARP] = { .type = NLA_U8 },