| Message ID | 20210610090307.2689-1-jslaby@suse.cz |
|---|---|
| State | New |
| Headers | show |
| Series | ipwireless: remove unused ipw_tty::closing | expand |
On Thu, Jun 10, 2021 at 11:03:07AM +0200, Jiri Slaby wrote:
> It's only set, but never read.
Thanks. Please update the changelog with:
Commit 01261cb94318 ("tty: ipwireless: Remove tty->closing abort from
ipw_open()") removed last use of tty::closing.
diff --git a/drivers/tty/ipwireless/tty.c b/drivers/tty/ipwireless/tty.c index e01ca68f24f4..e3a5a5ba752c 100644 --- a/drivers/tty/ipwireless/tty.c +++ b/drivers/tty/ipwireless/tty.c @@ -54,7 +54,6 @@ struct ipw_tty { unsigned int control_lines; struct mutex ipw_tty_mutex; int tx_bytes_queued; - int closing; }; static struct ipw_tty *ttys[IPWIRELESS_PCMCIA_MINORS]; @@ -525,7 +524,6 @@ void ipwireless_tty_free(struct ipw_tty *tty) printk(KERN_INFO IPWIRELESS_PCCARD_NAME ": deregistering %s device ttyIPWp%d\n", tty_type_name(ttyj->tty_type), j); - ttyj->closing = 1; if (ttyj->port.tty != NULL) { mutex_unlock(&ttyj->ipw_tty_mutex); tty_vhangup(ttyj->port.tty);
It's only set, but never read. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Jiri Kosina <jikos@kernel.org> Cc: David Sterba <dsterba@suse.com> --- drivers/tty/ipwireless/tty.c | 2 -- 1 file changed, 2 deletions(-)