| Message ID | 20210607091121.2766815-1-zhengyongjun3@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] xfrm: use BUG_ON instead of if condition followed by BUG | expand |
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index ce500f847b99..532314578151 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c @@ -421,8 +421,7 @@ void xfrm_policy_destroy(struct xfrm_policy *policy) { BUG_ON(!policy->walk.dead); - if (del_timer(&policy->timer) || del_timer(&policy->polq.hold_timer)) - BUG(); + BUG_ON(del_timer(&policy->timer) || del_timer(&policy->polq.hold_timer)); call_rcu(&policy->rcu, xfrm_policy_destroy_rcu); }
Use BUG_ON instead of if condition followed by BUG. This issue was detected with the help of Coccinelle. Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- net/xfrm/xfrm_policy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)