| Message ID | 1425656903-9388-1-git-send-email-taras.kondratiuk@linaro.org |
|---|---|
| State | Accepted |
| Commit | a0be37c8240875a71817edd925682471ee2af1fd |
| Headers | show |
On Fri, Mar 6, 2015 at 9:48 AM, Taras Kondratiuk < taras.kondratiuk@linaro.org> wrote: > Do not include platform-specific header files from common API headers. > > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > include/odp/api/pool.h | 2 -- > platform/linux-generic/include/odp/pool.h | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h > index 6fe52fa..241b98a 100644 > --- a/include/odp/api/pool.h > +++ b/include/odp/api/pool.h > @@ -21,8 +21,6 @@ extern "C" { > > > #include <odp/std_types.h> > -#include <odp/plat/shared_memory_types.h> > -#include <odp/event.h> > > /** @addtogroup odp_buffer > * Operations on a pool. > diff --git a/platform/linux-generic/include/odp/pool.h > b/platform/linux-generic/include/odp/pool.h > index e68b11e..02bc3b7 100644 > --- a/platform/linux-generic/include/odp/pool.h > +++ b/platform/linux-generic/include/odp/pool.h > @@ -26,6 +26,8 @@ extern "C" { > */ > > #include <odp/plat/pool_types.h> > +#include <odp/plat/shared_memory_types.h> > +#include <odp/plat/event_types.h> > #include <odp/api/pool.h> > > #ifdef __cplusplus > -- > 1.9.1 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 03/06/15 18:48, Taras Kondratiuk wrote: > Do not include platform-specific header files from common API headers. > > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > --- > include/odp/api/pool.h | 2 -- > platform/linux-generic/include/odp/pool.h | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h > index 6fe52fa..241b98a 100644 > --- a/include/odp/api/pool.h > +++ b/include/odp/api/pool.h > @@ -21,8 +21,6 @@ extern "C" { > > > #include <odp/std_types.h> > -#include <odp/plat/shared_memory_types.h> > -#include <odp/event.h> > > /** @addtogroup odp_buffer > * Operations on a pool. > diff --git a/platform/linux-generic/include/odp/pool.h b/platform/linux-generic/include/odp/pool.h > index e68b11e..02bc3b7 100644 > --- a/platform/linux-generic/include/odp/pool.h > +++ b/platform/linux-generic/include/odp/pool.h > @@ -26,6 +26,8 @@ extern "C" { > */ > > #include <odp/plat/pool_types.h> > +#include <odp/plat/shared_memory_types.h> > +#include <odp/plat/event_types.h> > #include <odp/api/pool.h> > > #ifdef __cplusplus
On 03/09/2015 01:05 PM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> > > > > /** Packet pool*/ > #define ODP_POOL_PACKET ODP_EVENT_PACKET > /** Buffer pool */ > #define ODP_POOL_BUFFER ODP_EVENT_BUFFER > /** Timeout pool */ > #define ODP_POOL_TIMEOUT ODP_EVENT_TIMEOUT > > In continuation, these define still linux-generic specific values and should be changed to spec only like this, > > /** > * @def ODP_POOL_PACKET > * Packet pool > */ > > > We may have similar definitions in other APIs also. Would you have time to check and send a patch for those. I'll do it for event.h first. Later will check for other headers also.
diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index 6fe52fa..241b98a 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -21,8 +21,6 @@ extern "C" { #include <odp/std_types.h> -#include <odp/plat/shared_memory_types.h> -#include <odp/event.h> /** @addtogroup odp_buffer * Operations on a pool. diff --git a/platform/linux-generic/include/odp/pool.h b/platform/linux-generic/include/odp/pool.h index e68b11e..02bc3b7 100644 --- a/platform/linux-generic/include/odp/pool.h +++ b/platform/linux-generic/include/odp/pool.h @@ -26,6 +26,8 @@ extern "C" { */ #include <odp/plat/pool_types.h> +#include <odp/plat/shared_memory_types.h> +#include <odp/plat/event_types.h> #include <odp/api/pool.h> #ifdef __cplusplus
Do not include platform-specific header files from common API headers. Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> --- include/odp/api/pool.h | 2 -- platform/linux-generic/include/odp/pool.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)