diff mbox series

[-next] scsi: mpi3mr: Fix error return code in mpi3mr_init_ioc()

Message ID 20210603151246.709016-1-yangyingliang@huawei.com
State New
Headers show
Series [-next] scsi: mpi3mr: Fix error return code in mpi3mr_init_ioc() | expand

Commit Message

Yang Yingliang June 3, 2021, 3:12 p.m. UTC 
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 824a156633df ("scsi: mpi3mr: Base driver code")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/scsi/mpi3mr/mpi3mr_fw.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
index acb2be62080a..b8ecbdf08b3c 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
@@ -3295,6 +3295,7 @@  int mpi3mr_init_ioc(struct mpi3mr_ioc *mrioc, u8 re_init)
 	}
 	ioc_state = mpi3mr_get_iocstate(mrioc);
 	if (ioc_state != MRIOC_STATE_RESET) {
+		retval = -1;
 		ioc_err(mrioc, "Cannot bring IOC to reset state\n");
 		goto out_failed;
 	}