| Message ID | 1425021151-26374-1-git-send-email-bala.manoharan@linaro.org |
|---|---|
| State | Accepted |
| Commit | f9900bf2612bf9f9a7f28082c59baf9d16335d9f |
| Headers | show |
On Fri, Feb 27, 2015 at 1:12 AM, <bala.manoharan@linaro.org> wrote: > From: Balasubramanian Manoharan <bala.manoharan@linaro.org> > > odp_pktio_skip_set() value is reset to zero as the validation suite expects > the skip value to be zero. > Fixes https://bugs.linaro.org/show_bug.cgi?id=1230 > > Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > test/validation/classification/odp_classification_tests.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/test/validation/classification/odp_classification_tests.c > b/test/validation/classification/odp_classification_tests.c > index fa37243..bd1bc3f 100644 > --- a/test/validation/classification/odp_classification_tests.c > +++ b/test/validation/classification/odp_classification_tests.c > @@ -533,6 +533,12 @@ static void classification_pktio_set_skip(void) > > retval = odp_pktio_skip_set(ODP_PKTIO_INVALID, offset); > CU_ASSERT(retval < 0); > + > + /* reset skip value to zero as validation suite expects > + offset to be zero*/ > + > + retval = odp_pktio_skip_set(pktio_loop, 0); > + CU_ASSERT(retval == 0); > } > > static void classification_pktio_set_headroom(void) > -- > 2.0.1.472.g6f92e5f > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Can this be merged now? Regards, Bala On 3 March 2015 at 06:07, Bill Fischofer <bill.fischofer@linaro.org> wrote: > > > On Fri, Feb 27, 2015 at 1:12 AM, <bala.manoharan@linaro.org> wrote: >> >> From: Balasubramanian Manoharan <bala.manoharan@linaro.org> >> >> odp_pktio_skip_set() value is reset to zero as the validation suite >> expects >> the skip value to be zero. >> Fixes https://bugs.linaro.org/show_bug.cgi?id=1230 >> >> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > > > Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> > >> >> --- >> test/validation/classification/odp_classification_tests.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/test/validation/classification/odp_classification_tests.c >> b/test/validation/classification/odp_classification_tests.c >> index fa37243..bd1bc3f 100644 >> --- a/test/validation/classification/odp_classification_tests.c >> +++ b/test/validation/classification/odp_classification_tests.c >> @@ -533,6 +533,12 @@ static void classification_pktio_set_skip(void) >> >> retval = odp_pktio_skip_set(ODP_PKTIO_INVALID, offset); >> CU_ASSERT(retval < 0); >> + >> + /* reset skip value to zero as validation suite expects >> + offset to be zero*/ >> + >> + retval = odp_pktio_skip_set(pktio_loop, 0); >> + CU_ASSERT(retval == 0); >> } >> >> static void classification_pktio_set_headroom(void) >> -- >> 2.0.1.472.g6f92e5f >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp > >
Per Maxim's post this was merged earlier today. Commit id is f9900bf2612bf9f9a7f28082c59baf9d16335d9f On Tue, Mar 3, 2015 at 1:23 PM, Bala Manoharan <bala.manoharan@linaro.org> wrote: > Can this be merged now? > > Regards, > Bala > > On 3 March 2015 at 06:07, Bill Fischofer <bill.fischofer@linaro.org> > wrote: > > > > > > On Fri, Feb 27, 2015 at 1:12 AM, <bala.manoharan@linaro.org> wrote: > >> > >> From: Balasubramanian Manoharan <bala.manoharan@linaro.org> > >> > >> odp_pktio_skip_set() value is reset to zero as the validation suite > >> expects > >> the skip value to be zero. > >> Fixes https://bugs.linaro.org/show_bug.cgi?id=1230 > >> > >> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > > > > > > Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> > > > >> > >> --- > >> test/validation/classification/odp_classification_tests.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/test/validation/classification/odp_classification_tests.c > >> b/test/validation/classification/odp_classification_tests.c > >> index fa37243..bd1bc3f 100644 > >> --- a/test/validation/classification/odp_classification_tests.c > >> +++ b/test/validation/classification/odp_classification_tests.c > >> @@ -533,6 +533,12 @@ static void classification_pktio_set_skip(void) > >> > >> retval = odp_pktio_skip_set(ODP_PKTIO_INVALID, offset); > >> CU_ASSERT(retval < 0); > >> + > >> + /* reset skip value to zero as validation suite expects > >> + offset to be zero*/ > >> + > >> + retval = odp_pktio_skip_set(pktio_loop, 0); > >> + CU_ASSERT(retval == 0); > >> } > >> > >> static void classification_pktio_set_headroom(void) > >> -- > >> 2.0.1.472.g6f92e5f > >> > >> > >> _______________________________________________ > >> lng-odp mailing list > >> lng-odp@lists.linaro.org > >> http://lists.linaro.org/mailman/listinfo/lng-odp > > > > >
Sorry there were two patches and I had missed this commit id. Regards, Bala On Wednesday 04 March 2015 12:55 AM, Bill Fischofer wrote: > Per Maxim's post this was merged earlier today. Commit id > is f9900bf2612bf9f9a7f28082c59baf9d16335d9f > > On Tue, Mar 3, 2015 at 1:23 PM, Bala Manoharan <bala.manoharan@linaro.org> > wrote: > >> Can this be merged now? >> >> Regards, >> Bala >> >> On 3 March 2015 at 06:07, Bill Fischofer <bill.fischofer@linaro.org> >> wrote: >>> >>> On Fri, Feb 27, 2015 at 1:12 AM, <bala.manoharan@linaro.org> wrote: >>>> From: Balasubramanian Manoharan <bala.manoharan@linaro.org> >>>> >>>> odp_pktio_skip_set() value is reset to zero as the validation suite >>>> expects >>>> the skip value to be zero. >>>> Fixes https://bugs.linaro.org/show_bug.cgi?id=1230 >>>> >>>> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> >>> >>> Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> >>> >>>> --- >>>> test/validation/classification/odp_classification_tests.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/test/validation/classification/odp_classification_tests.c >>>> b/test/validation/classification/odp_classification_tests.c >>>> index fa37243..bd1bc3f 100644 >>>> --- a/test/validation/classification/odp_classification_tests.c >>>> +++ b/test/validation/classification/odp_classification_tests.c >>>> @@ -533,6 +533,12 @@ static void classification_pktio_set_skip(void) >>>> >>>> retval = odp_pktio_skip_set(ODP_PKTIO_INVALID, offset); >>>> CU_ASSERT(retval < 0); >>>> + >>>> + /* reset skip value to zero as validation suite expects >>>> + offset to be zero*/ >>>> + >>>> + retval = odp_pktio_skip_set(pktio_loop, 0); >>>> + CU_ASSERT(retval == 0); >>>> } >>>> >>>> static void classification_pktio_set_headroom(void) >>>> -- >>>> 2.0.1.472.g6f92e5f >>>> >>>> >>>> _______________________________________________ >>>> lng-odp mailing list >>>> lng-odp@lists.linaro.org >>>> http://lists.linaro.org/mailman/listinfo/lng-odp >>>
diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c index fa37243..bd1bc3f 100644 --- a/test/validation/classification/odp_classification_tests.c +++ b/test/validation/classification/odp_classification_tests.c @@ -533,6 +533,12 @@ static void classification_pktio_set_skip(void) retval = odp_pktio_skip_set(ODP_PKTIO_INVALID, offset); CU_ASSERT(retval < 0); + + /* reset skip value to zero as validation suite expects + offset to be zero*/ + + retval = odp_pktio_skip_set(pktio_loop, 0); + CU_ASSERT(retval == 0); } static void classification_pktio_set_headroom(void)