diff mbox

validation: crypto: destroy session in case of failure

Message ID 1424991395-28433-1-git-send-email-taras.kondratiuk@linaro.org
State Accepted
Commit a3a87d4eba8e27a68630eacfbe91d9d767ea1255
Headers show

Commit Message

Taras Kondratiuk Feb. 26, 2015, 10:56 p.m. UTC
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
---
 test/validation/crypto/odp_crypto_test_async_inp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Bill Fischofer Feb. 26, 2015, 11:40 p.m. UTC | #1
On Thu, Feb 26, 2015 at 4:56 PM, Taras Kondratiuk <
taras.kondratiuk@linaro.org> wrote:

> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>  test/validation/crypto/odp_crypto_test_async_inp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/validation/crypto/odp_crypto_test_async_inp.c
> b/test/validation/crypto/odp_crypto_test_async_inp.c
> index aff93da..9e4e9f1 100644
> --- a/test/validation/crypto/odp_crypto_test_async_inp.c
> +++ b/test/validation/crypto/odp_crypto_test_async_inp.c
> @@ -92,8 +92,8 @@ static void alg_test(enum odp_crypto_op op,
>
>         rc = odp_crypto_operation(&op_params, &posted, NULL);
>         if (rc < 0) {
> -               odp_packet_free(pkt);
> -               CU_FAIL_FATAL("Failed odp_crypto_operation()");
> +               CU_FAIL("Failed odp_crypto_operation()");
> +               goto cleanup;
>         }
>         CU_ASSERT(posted);
>
> @@ -112,7 +112,7 @@ static void alg_test(enum odp_crypto_op op,
>         CU_ASSERT(!memcmp(data_addr, output_vec, output_vec_len));
>
>         CU_ASSERT(result.ctx == (void *)0xdeadbeef);
> -
> +cleanup:
>         rc = odp_crypto_session_destroy(session);
>         CU_ASSERT(!rc);
>
> --
> 1.9.1
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
diff mbox

Patch

diff --git a/test/validation/crypto/odp_crypto_test_async_inp.c b/test/validation/crypto/odp_crypto_test_async_inp.c
index aff93da..9e4e9f1 100644
--- a/test/validation/crypto/odp_crypto_test_async_inp.c
+++ b/test/validation/crypto/odp_crypto_test_async_inp.c
@@ -92,8 +92,8 @@  static void alg_test(enum odp_crypto_op op,
 
 	rc = odp_crypto_operation(&op_params, &posted, NULL);
 	if (rc < 0) {
-		odp_packet_free(pkt);
-		CU_FAIL_FATAL("Failed odp_crypto_operation()");
+		CU_FAIL("Failed odp_crypto_operation()");
+		goto cleanup;
 	}
 	CU_ASSERT(posted);
 
@@ -112,7 +112,7 @@  static void alg_test(enum odp_crypto_op op,
 	CU_ASSERT(!memcmp(data_addr, output_vec, output_vec_len));
 
 	CU_ASSERT(result.ctx == (void *)0xdeadbeef);
-
+cleanup:
 	rc = odp_crypto_session_destroy(session);
 	CU_ASSERT(!rc);