| Message ID | 1424856621-26539-1-git-send-email-taras.kondratiuk@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4a6a86ce8d17e6bec892fb8765df1b689378d357 |
| Headers | show |
ping On 02/25/2015 11:30 AM, Taras Kondratiuk wrote: > stdarg.h is not needed in odp_debug_internal.h, but instead should be > included in odp_weak.c. > > The change is needed to be able to reuse odp_weak.c from other > platforms. > > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > --- > platform/linux-generic/include/odp_debug_internal.h | 1 - > platform/linux-generic/odp_weak.c | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/platform/linux-generic/include/odp_debug_internal.h b/platform/linux-generic/include/odp_debug_internal.h > index ff43ffc..d9ac812 100644 > --- a/platform/linux-generic/include/odp_debug_internal.h > +++ b/platform/linux-generic/include/odp_debug_internal.h > @@ -18,7 +18,6 @@ > > #include <stdio.h> > #include <stdlib.h> > -#include <stdarg.h> > #include <odp/debug.h> > #include <odp_internal.h> > #ifdef __cplusplus > diff --git a/platform/linux-generic/odp_weak.c b/platform/linux-generic/odp_weak.c > index 9dc3a4a..9641f45 100644 > --- a/platform/linux-generic/odp_weak.c > +++ b/platform/linux-generic/odp_weak.c > @@ -9,6 +9,8 @@ > #include <odp_debug_internal.h> > #include <odp/hints.h> > > +#include <stdarg.h> > + > ODP_WEAK_SYMBOL int odp_override_log(odp_log_level_e level ODP_UNUSED, > const char *fmt, ...) > { >
On Wed, Feb 25, 2015 at 3:30 AM, Taras Kondratiuk < taras.kondratiuk@linaro.org> wrote: > stdarg.h is not needed in odp_debug_internal.h, but instead should be > included in odp_weak.c. > > The change is needed to be able to reuse odp_weak.c from other > platforms. > > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > platform/linux-generic/include/odp_debug_internal.h | 1 - > platform/linux-generic/odp_weak.c | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/platform/linux-generic/include/odp_debug_internal.h > b/platform/linux-generic/include/odp_debug_internal.h > index ff43ffc..d9ac812 100644 > --- a/platform/linux-generic/include/odp_debug_internal.h > +++ b/platform/linux-generic/include/odp_debug_internal.h > @@ -18,7 +18,6 @@ > > #include <stdio.h> > #include <stdlib.h> > -#include <stdarg.h> > #include <odp/debug.h> > #include <odp_internal.h> > #ifdef __cplusplus > diff --git a/platform/linux-generic/odp_weak.c > b/platform/linux-generic/odp_weak.c > index 9dc3a4a..9641f45 100644 > --- a/platform/linux-generic/odp_weak.c > +++ b/platform/linux-generic/odp_weak.c > @@ -9,6 +9,8 @@ > #include <odp_debug_internal.h> > #include <odp/hints.h> > > +#include <stdarg.h> > + > ODP_WEAK_SYMBOL int odp_override_log(odp_log_level_e level ODP_UNUSED, > const char *fmt, ...) > { > -- > 1.9.1 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
I was not able to apply this to check. On 6 March 2015 at 11:26, Bill Fischofer <bill.fischofer@linaro.org> wrote: > > > On Wed, Feb 25, 2015 at 3:30 AM, Taras Kondratiuk < > taras.kondratiuk@linaro.org> wrote: > >> stdarg.h is not needed in odp_debug_internal.h, but instead should be >> included in odp_weak.c. >> >> The change is needed to be able to reuse odp_weak.c from other >> platforms. >> >> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> >> > > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > > >> --- >> platform/linux-generic/include/odp_debug_internal.h | 1 - >> platform/linux-generic/odp_weak.c | 2 ++ >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/platform/linux-generic/include/odp_debug_internal.h >> b/platform/linux-generic/include/odp_debug_internal.h >> index ff43ffc..d9ac812 100644 >> --- a/platform/linux-generic/include/odp_debug_internal.h >> +++ b/platform/linux-generic/include/odp_debug_internal.h >> @@ -18,7 +18,6 @@ >> >> #include <stdio.h> >> #include <stdlib.h> >> -#include <stdarg.h> >> #include <odp/debug.h> >> #include <odp_internal.h> >> #ifdef __cplusplus >> diff --git a/platform/linux-generic/odp_weak.c >> b/platform/linux-generic/odp_weak.c >> index 9dc3a4a..9641f45 100644 >> --- a/platform/linux-generic/odp_weak.c >> +++ b/platform/linux-generic/odp_weak.c >> @@ -9,6 +9,8 @@ >> #include <odp_debug_internal.h> >> #include <odp/hints.h> >> >> +#include <stdarg.h> >> + >> ODP_WEAK_SYMBOL int odp_override_log(odp_log_level_e level ODP_UNUSED, >> const char *fmt, ...) >> { >> -- >> 1.9.1 >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp > >
It probably needs a rebase. On Fri, Mar 6, 2015 at 10:29 AM, Mike Holmes <mike.holmes@linaro.org> wrote: > I was not able to apply this to check. > > On 6 March 2015 at 11:26, Bill Fischofer <bill.fischofer@linaro.org> > wrote: > >> >> >> On Wed, Feb 25, 2015 at 3:30 AM, Taras Kondratiuk < >> taras.kondratiuk@linaro.org> wrote: >> >>> stdarg.h is not needed in odp_debug_internal.h, but instead should be >>> included in odp_weak.c. >>> >>> The change is needed to be able to reuse odp_weak.c from other >>> platforms. >>> >>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> >>> >> >> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> >> >> >>> --- >>> platform/linux-generic/include/odp_debug_internal.h | 1 - >>> platform/linux-generic/odp_weak.c | 2 ++ >>> 2 files changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/platform/linux-generic/include/odp_debug_internal.h >>> b/platform/linux-generic/include/odp_debug_internal.h >>> index ff43ffc..d9ac812 100644 >>> --- a/platform/linux-generic/include/odp_debug_internal.h >>> +++ b/platform/linux-generic/include/odp_debug_internal.h >>> @@ -18,7 +18,6 @@ >>> >>> #include <stdio.h> >>> #include <stdlib.h> >>> -#include <stdarg.h> >>> #include <odp/debug.h> >>> #include <odp_internal.h> >>> #ifdef __cplusplus >>> diff --git a/platform/linux-generic/odp_weak.c >>> b/platform/linux-generic/odp_weak.c >>> index 9dc3a4a..9641f45 100644 >>> --- a/platform/linux-generic/odp_weak.c >>> +++ b/platform/linux-generic/odp_weak.c >>> @@ -9,6 +9,8 @@ >>> #include <odp_debug_internal.h> >>> #include <odp/hints.h> >>> >>> +#include <stdarg.h> >>> + >>> ODP_WEAK_SYMBOL int odp_override_log(odp_log_level_e level ODP_UNUSED, >>> const char *fmt, ...) >>> { >>> -- >>> 1.9.1 >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > > >
On 03/06/15 19:29, Mike Holmes wrote: > I was not able to apply this to check. > Common, 3 lines patch one of that line is empty ;) Tested for x86 and arm. Applied! Maxim. > On 6 March 2015 at 11:26, Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> wrote: > > > > On Wed, Feb 25, 2015 at 3:30 AM, Taras Kondratiuk > <taras.kondratiuk@linaro.org <mailto:taras.kondratiuk@linaro.org>> > wrote: > > stdarg.h is not needed in odp_debug_internal.h, but instead > should be > included in odp_weak.c. > > The change is needed to be able to reuse odp_weak.c from other > platforms. > > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org > <mailto:taras.kondratiuk@linaro.org>> > > > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > > --- > platform/linux-generic/include/odp_debug_internal.h | 1 - > platform/linux-generic/odp_weak.c | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/platform/linux-generic/include/odp_debug_internal.h > b/platform/linux-generic/include/odp_debug_internal.h > index ff43ffc..d9ac812 100644 > --- a/platform/linux-generic/include/odp_debug_internal.h > +++ b/platform/linux-generic/include/odp_debug_internal.h > @@ -18,7 +18,6 @@ > > #include <stdio.h> > #include <stdlib.h> > -#include <stdarg.h> > #include <odp/debug.h> > #include <odp_internal.h> > #ifdef __cplusplus > diff --git a/platform/linux-generic/odp_weak.c > b/platform/linux-generic/odp_weak.c > index 9dc3a4a..9641f45 100644 > --- a/platform/linux-generic/odp_weak.c > +++ b/platform/linux-generic/odp_weak.c > @@ -9,6 +9,8 @@ > #include <odp_debug_internal.h> > #include <odp/hints.h> > > +#include <stdarg.h> > + > ODP_WEAK_SYMBOL int odp_override_log(odp_log_level_e level > ODP_UNUSED, > const char *fmt, ...) > { > -- > 1.9.1 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > http://lists.linaro.org/mailman/listinfo/lng-odp > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > http://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/platform/linux-generic/include/odp_debug_internal.h b/platform/linux-generic/include/odp_debug_internal.h index ff43ffc..d9ac812 100644 --- a/platform/linux-generic/include/odp_debug_internal.h +++ b/platform/linux-generic/include/odp_debug_internal.h @@ -18,7 +18,6 @@ #include <stdio.h> #include <stdlib.h> -#include <stdarg.h> #include <odp/debug.h> #include <odp_internal.h> #ifdef __cplusplus diff --git a/platform/linux-generic/odp_weak.c b/platform/linux-generic/odp_weak.c index 9dc3a4a..9641f45 100644 --- a/platform/linux-generic/odp_weak.c +++ b/platform/linux-generic/odp_weak.c @@ -9,6 +9,8 @@ #include <odp_debug_internal.h> #include <odp/hints.h> +#include <stdarg.h> + ODP_WEAK_SYMBOL int odp_override_log(odp_log_level_e level ODP_UNUSED, const char *fmt, ...) {
stdarg.h is not needed in odp_debug_internal.h, but instead should be included in odp_weak.c. The change is needed to be able to reuse odp_weak.c from other platforms. Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> --- platform/linux-generic/include/odp_debug_internal.h | 1 - platform/linux-generic/odp_weak.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)