| Message ID | 20210527072217.117126-1-hare@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION | expand |
On 5/27/21 12:22 AM, Hannes Reinecke wrote: > The nsp_cs driver stores the SAM status values in SCp.Status, so > we need to use the non-shifted version SAM_STAT_CHECK_CONDITION. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > drivers/scsi/pcmcia/nsp_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c > index ac89002646a3..7c0f931e55e8 100644 > --- a/drivers/scsi/pcmcia/nsp_cs.c > +++ b/drivers/scsi/pcmcia/nsp_cs.c > @@ -221,7 +221,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt, > > data->CurrentSC = SCpnt; > > - SCpnt->SCp.Status = CHECK_CONDITION; > + SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION; > SCpnt->SCp.Message = 0; > SCpnt->SCp.have_data_in = IO_UNKNOWN; > SCpnt->SCp.sent_command = 0; Since this patch is a bug fix, does this patch need a Cc: stable tag? I'm not sure how to add a Fixes: tag since this bug predates Linux kernel v2.6.12. Thanks, Bart.
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c index ac89002646a3..7c0f931e55e8 100644 --- a/drivers/scsi/pcmcia/nsp_cs.c +++ b/drivers/scsi/pcmcia/nsp_cs.c @@ -221,7 +221,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt, data->CurrentSC = SCpnt; - SCpnt->SCp.Status = CHECK_CONDITION; + SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION; SCpnt->SCp.Message = 0; SCpnt->SCp.have_data_in = IO_UNKNOWN; SCpnt->SCp.sent_command = 0;
The nsp_cs driver stores the SAM status values in SCp.Status, so we need to use the non-shifted version SAM_STAT_CHECK_CONDITION. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/pcmcia/nsp_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)