| Message ID | 20210525200246.118323-1-konrad.dybcio@somainline.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/7] arm64: dts: qcom: Add PMI8996 DTSI file | expand |
Hi, > So I'm supposed to include this and the pmi8994? I was expecting an > include of pmi8994.dtsi from here and then some override of the > necessary properties. This way we would have to get three dts files for each device: one for device-common stuff, one including pmi8994 and one including pmi8996. Otherwise pmi8994 contents would be included twice, as the "base" device dt already includes pmi8994. If you check how I solved that on Tone, I just took the pmi8994-equipped phone dt as a baseline and only included this small dtsi as an overlay on top. Konrad
diff --git a/arch/arm64/boot/dts/qcom/pmi8996.dtsi b/arch/arm64/boot/dts/qcom/pmi8996.dtsi new file mode 100644 index 000000000000..31b47209e261 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/pmi8996.dtsi @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2021, Konrad Dybcio <konrad.dybcio@somainline.org> + */ + + /* + * PMI8996 is a slight modification of PMI8994 with + * some notable changes, like being the first PMIC + * whose the bootloader has to check to continue booting + * and a change to a LABIBB parameter. + */ + +/ { + qcom,pmic-id = <0x20009 0x10013 0 0>; +};
PMI8996 is *almost* the same hardware as PMI8994, say for some annoyances: - Boards equipped with PMI8996 now have to include pmic-id (which wasn't the case before) - Different qpnp-ibb-discharge-resistor value (will be addressed after LABIBB is introduced) - Different inhibit-derating-ua value (will be addressed after BCL is introduced) - Different ramp_up_step value (will be addressed after [if?] QPNP Flash LED is introduced) Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- arch/arm64/boot/dts/qcom/pmi8996.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/pmi8996.dtsi