diff mbox

[6/6] linux-generic: move imp API number def to header file

Message ID 1423638605-6342-7-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov Feb. 11, 2015, 7:10 a.m. UTC 
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 platform/linux-generic/include/odp/version.h | 3 +++
 platform/linux-generic/odp_version.c         | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Taras Kondratiuk Feb. 16, 2015, 11:48 a.m. UTC | #1 
On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  platform/linux-generic/include/odp/version.h | 3 +++
>  platform/linux-generic/odp_version.c         | 3 ---
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/platform/linux-generic/include/odp/version.h b/platform/linux-generic/include/odp/version.h
> index b5071e5..8a95221 100644
> --- a/platform/linux-generic/include/odp/version.h
> +++ b/platform/linux-generic/include/odp/version.h
> @@ -31,6 +31,9 @@ ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR)
>  
>  #include <odp/api/version.h>
>  
> +#define  ODP_VERSION_IMPL 0
> +#define  ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL)
> +

These macros are not part of an ODP API. Why they are moved here?

>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/platform/linux-generic/odp_version.c b/platform/linux-generic/odp_version.c
> index d54580c..776f4da 100644
> --- a/platform/linux-generic/odp_version.c
> +++ b/platform/linux-generic/odp_version.c
> @@ -16,9 +16,6 @@ const char *odp_version_api_str(void)
>  	return ODP_VERSION_API_STR;
>  }
>  
> -#define  ODP_VERSION_IMPL 0
> -#define  ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL)
> -
>  const char *odp_version_impl_str(void)
>  {
>  	return ODP_VERSION_IMPL_STR;
>
Maxim Uvarov Feb. 16, 2015, 12:06 p.m. UTC | #2 
On 02/16/2015 02:48 PM, Taras Kondratiuk wrote:
> On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
>> ---
>>   platform/linux-generic/include/odp/version.h | 3 +++
>>   platform/linux-generic/odp_version.c         | 3 ---
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/platform/linux-generic/include/odp/version.h b/platform/linux-generic/include/odp/version.h
>> index b5071e5..8a95221 100644
>> --- a/platform/linux-generic/include/odp/version.h
>> +++ b/platform/linux-generic/include/odp/version.h
>> @@ -31,6 +31,9 @@ ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR)
>>   
>>   #include <odp/api/version.h>
>>   
>> +#define  ODP_VERSION_IMPL 0
>> +#define  ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL)
>> +
> These macros are not part of an ODP API. Why they are moved here?

Right, it's not ODP API. It's platfrom/linux-generic.


Maxim.
>
>>   #ifdef __cplusplus
>>   }
>>   #endif
>> diff --git a/platform/linux-generic/odp_version.c b/platform/linux-generic/odp_version.c
>> index d54580c..776f4da 100644
>> --- a/platform/linux-generic/odp_version.c
>> +++ b/platform/linux-generic/odp_version.c
>> @@ -16,9 +16,6 @@ const char *odp_version_api_str(void)
>>   	return ODP_VERSION_API_STR;
>>   }
>>   
>> -#define  ODP_VERSION_IMPL 0
>> -#define  ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL)
>> -
>>   const char *odp_version_impl_str(void)
>>   {
>>   	return ODP_VERSION_IMPL_STR;
>>
>
diff mbox

Patch

diff --git a/platform/linux-generic/include/odp/version.h b/platform/linux-generic/include/odp/version.h
index b5071e5..8a95221 100644
--- a/platform/linux-generic/include/odp/version.h
+++ b/platform/linux-generic/include/odp/version.h
@@ -31,6 +31,9 @@  ODP_VERSION_TO_STR(ODP_VERSION_API_MINOR)
 
 #include <odp/api/version.h>
 
+#define  ODP_VERSION_IMPL 0
+#define  ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL)
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/platform/linux-generic/odp_version.c b/platform/linux-generic/odp_version.c
index d54580c..776f4da 100644
--- a/platform/linux-generic/odp_version.c
+++ b/platform/linux-generic/odp_version.c
@@ -16,9 +16,6 @@  const char *odp_version_api_str(void)
 	return ODP_VERSION_API_STR;
 }
 
-#define  ODP_VERSION_IMPL 0
-#define  ODP_VERSION_IMPL_STR ODP_VERSION_TO_STR(ODP_VERSION_IMPL)
-
 const char *odp_version_impl_str(void)
 {
 	return ODP_VERSION_IMPL_STR;