| Message ID | 1423127619-20674-1-git-send-email-taras.kondratiuk@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 02/05/2015 11:13 AM, Taras Kondratiuk wrote: > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > --- > include/odp/api/hints.h | 12 ++++++++++++ > platform/linux-generic/include/odp_debug_internal.h | 19 ------------------- > 2 files changed, 12 insertions(+), 19 deletions(-) A there any objections for this patch?
On 02/26/2015 01:47 PM, Taras Kondratiuk wrote: > On 02/05/2015 11:13 AM, Taras Kondratiuk wrote: >> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> >> --- >> include/odp/api/hints.h | 12 ++++++++++++ >> platform/linux-generic/include/odp_debug_internal.h | 19 ------------------- >> 2 files changed, 12 insertions(+), 19 deletions(-) > > A there any objections for this patch? > Sorry, that supposed to be: Are there any objections to this patch?
The subject say api: not linux-generic becasue it alters the public api. On 26 February 2015 at 06:49, Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote: > On 02/26/2015 01:47 PM, Taras Kondratiuk wrote: > > On 02/05/2015 11:13 AM, Taras Kondratiuk wrote: > >> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > >> --- > >> include/odp/api/hints.h | 12 ++++++++++++ > >> platform/linux-generic/include/odp_debug_internal.h | 19 > ------------------- > >> 2 files changed, 12 insertions(+), 19 deletions(-) > > > > A there any objections for this patch? > > > Sorry, that supposed to be: > Are there any objections to this patch? > > -- > Taras Kondratiuk > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 02/26/2015 01:56 PM, Mike Holmes wrote:
> The subject say api: not linux-generic becasue it alters the public api.
Maybe move hints.h into helpers directory?
They are not real ODP API.
On 26 February 2015 at 07:01, Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote: > On 02/26/2015 01:56 PM, Mike Holmes wrote: > > The subject say api: not linux-generic becasue it alters the public api. > > Maybe move hints.h into helpers directory? They are not real ODP API. > Agree they are not part of the interface in that way, but they do touch the files, I know folks who are grepping on api: to filter mail for what matters - i.e. changes to those files. > > -- > Taras Kondratiuk >
diff --git a/include/odp/api/hints.h b/include/odp/api/hints.h index a7aa90e..ebf83fc 100644 --- a/include/odp/api/hints.h +++ b/include/odp/api/hints.h @@ -46,6 +46,16 @@ extern "C" { #define ODP_COLD_CODE __attribute__((__cold__)) /** + * Indicate deprecated variables, functions or types + */ +#define ODP_DEPRECATED __attribute__((__deprecated__)) + +/** + * Intentionally unused variables ot functions + */ +#define ODP_UNUSED __attribute__((__unused__)) + +/** * Branch likely taken */ #define odp_likely(x) __builtin_expect((x), 1) @@ -80,6 +90,8 @@ extern "C" { #define ODP_WEAK_SYMBOL #define ODP_HOT_CODE #define ODP_COLD_CODE +#define ODP_DEPRECATED +#define ODP_UNUSED #define odp_likely(x) #define odp_unlikely(x) #define odp_prefetch(x) diff --git a/platform/linux-generic/include/odp_debug_internal.h b/platform/linux-generic/include/odp_debug_internal.h index 2b643eb..dec5c15 100644 --- a/platform/linux-generic/include/odp_debug_internal.h +++ b/platform/linux-generic/include/odp_debug_internal.h @@ -29,25 +29,6 @@ extern "C" { * @{ */ -#ifdef __GNUC__ - -/** - * Indicate deprecated variables, functions or types - */ -#define ODP_DEPRECATED __attribute__((__deprecated__)) - -/** - * Intentionally unused variables ot functions - */ -#define ODP_UNUSED __attribute__((__unused__)) - -#else - -#define ODP_DEPRECATED -#define ODP_UNUSED - -#endif - /** * Runtime assertion-macro - aborts if 'cond' is false. */
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> --- include/odp/api/hints.h | 12 ++++++++++++ platform/linux-generic/include/odp_debug_internal.h | 19 ------------------- 2 files changed, 12 insertions(+), 19 deletions(-)