diff mbox series

[20/38] drm/radeon/radeon_vm: Fix function naming disparities

Message ID 20210520120248.3464013-21-lee.jones@linaro.org
State Accepted
Commit 52456b426b6525ff6b8ab3a0b21a257995880272
Headers show
Series Rid W=1 warnings from GPU | expand

Commit Message

Lee Jones May 20, 2021, 12:02 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead
 drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.31.1

Comments

Christian König May 20, 2021, 12:05 p.m. UTC | #1
Am 20.05.21 um 14:02 schrieb Lee Jones:
> Fixes the following W=1 kernel build warning(s):

>

>   drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead

>   drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead

>

> Cc: Alex Deucher <alexander.deucher@amd.com>

> Cc: "Christian König" <christian.koenig@amd.com>

> Cc: David Airlie <airlied@linux.ie>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Cc: amd-gfx@lists.freedesktop.org

> Cc: dri-devel@lists.freedesktop.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Christian König <christian.koenig@amd.com>


> ---

>   drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--

>   1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c

> index 2dc9c9f98049b..36a38adaaea96 100644

> --- a/drivers/gpu/drm/radeon/radeon_vm.c

> +++ b/drivers/gpu/drm/radeon/radeon_vm.c

> @@ -51,7 +51,7 @@

>    */

>   

>   /**

> - * radeon_vm_num_pde - return the number of page directory entries

> + * radeon_vm_num_pdes - return the number of page directory entries

>    *

>    * @rdev: radeon_device pointer

>    *

> @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags)

>   }

>   

>   /**

> - * radeon_vm_update_pdes - make sure that page directory is valid

> + * radeon_vm_update_page_directory - make sure that page directory is valid

>    *

>    * @rdev: radeon_device pointer

>    * @vm: requested vm
Alex Deucher May 20, 2021, 7:16 p.m. UTC | #2
Applied.  Thanks!


On Thu, May 20, 2021 at 8:05 AM Christian König
<christian.koenig@amd.com> wrote:
>

> Am 20.05.21 um 14:02 schrieb Lee Jones:

> > Fixes the following W=1 kernel build warning(s):

> >

> >   drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead

> >   drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead

> >

> > Cc: Alex Deucher <alexander.deucher@amd.com>

> > Cc: "Christian König" <christian.koenig@amd.com>

> > Cc: David Airlie <airlied@linux.ie>

> > Cc: Daniel Vetter <daniel@ffwll.ch>

> > Cc: amd-gfx@lists.freedesktop.org

> > Cc: dri-devel@lists.freedesktop.org

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

>

> Reviewed-by: Christian König <christian.koenig@amd.com>

>

> > ---

> >   drivers/gpu/drm/radeon/radeon_vm.c | 4 ++--

> >   1 file changed, 2 insertions(+), 2 deletions(-)

> >

> > diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c

> > index 2dc9c9f98049b..36a38adaaea96 100644

> > --- a/drivers/gpu/drm/radeon/radeon_vm.c

> > +++ b/drivers/gpu/drm/radeon/radeon_vm.c

> > @@ -51,7 +51,7 @@

> >    */

> >

> >   /**

> > - * radeon_vm_num_pde - return the number of page directory entries

> > + * radeon_vm_num_pdes - return the number of page directory entries

> >    *

> >    * @rdev: radeon_device pointer

> >    *

> > @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags)

> >   }

> >

> >   /**

> > - * radeon_vm_update_pdes - make sure that page directory is valid

> > + * radeon_vm_update_page_directory - make sure that page directory is valid

> >    *

> >    * @rdev: radeon_device pointer

> >    * @vm: requested vm

>

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
index 2dc9c9f98049b..36a38adaaea96 100644
--- a/drivers/gpu/drm/radeon/radeon_vm.c
+++ b/drivers/gpu/drm/radeon/radeon_vm.c
@@ -51,7 +51,7 @@ 
  */
 
 /**
- * radeon_vm_num_pde - return the number of page directory entries
+ * radeon_vm_num_pdes - return the number of page directory entries
  *
  * @rdev: radeon_device pointer
  *
@@ -626,7 +626,7 @@  static uint32_t radeon_vm_page_flags(uint32_t flags)
 }
 
 /**
- * radeon_vm_update_pdes - make sure that page directory is valid
+ * radeon_vm_update_page_directory - make sure that page directory is valid
  *
  * @rdev: radeon_device pointer
  * @vm: requested vm