| Message ID | 20210519070545.1728197-1-aisheng.dong@nxp.com |
|---|---|
| State | Accepted |
| Commit | 7dbc0d246891acbb8ae5840b3237881b7a0787df |
| Headers | show |
| Series | [1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status | expand |
On 5/19/21 4:05 PM, Dong Aisheng wrote: > Current driver actually does not support simple ondemand governor > as it's unable to provide device load information. So removing > the unnecessary callback to avoid confusing. > Right now the driver is using userspace governor by default. > > polling_ms was also dropped as it's not needed for non-ondemand > governor. > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/devfreq/imx-bus.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c > index 3fc3fd77492d..f3f6e25053ed 100644 > --- a/drivers/devfreq/imx-bus.c > +++ b/drivers/devfreq/imx-bus.c > @@ -45,18 +45,6 @@ static int imx_bus_get_cur_freq(struct device *dev, unsigned long *freq) > return 0; > } > > -static int imx_bus_get_dev_status(struct device *dev, > - struct devfreq_dev_status *stat) > -{ > - struct imx_bus *priv = dev_get_drvdata(dev); > - > - stat->busy_time = 0; > - stat->total_time = 0; > - stat->current_frequency = clk_get_rate(priv->clk); > - > - return 0; > -} > - > static void imx_bus_exit(struct device *dev) > { > struct imx_bus *priv = dev_get_drvdata(dev); > @@ -129,9 +117,7 @@ static int imx_bus_probe(struct platform_device *pdev) > return ret; > } > > - priv->profile.polling_ms = 1000; > priv->profile.target = imx_bus_target; > - priv->profile.get_dev_status = imx_bus_get_dev_status; > priv->profile.exit = imx_bus_exit; > priv->profile.get_cur_freq = imx_bus_get_cur_freq; > priv->profile.initial_freq = clk_get_rate(priv->clk); > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics
On 5/19/21 4:05 PM, Dong Aisheng wrote: > The driver can't support simple ondemand governor due to missing > .get_dev_status() capability. > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/devfreq/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 20373a893b44..e87d01c0b76a 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ > tristate "i.MX8M DDRC DEVFREQ Driver" > depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \ > (COMPILE_TEST && HAVE_ARM_SMCCC) > - select DEVFREQ_GOV_SIMPLE_ONDEMAND > select DEVFREQ_GOV_USERSPACE > help > This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows > Looks good to me. But, How about changing the patch title as following? - PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND dependency -- Best Regards, Chanwoo Choi Samsung Electronics
> From: Chanwoo Choi <cw00.choi@samsung.com> > Sent: Thursday, May 20, 2021 11:10 AM > > On 5/19/21 4:05 PM, Dong Aisheng wrote: > > The driver can't support simple ondemand governor due to missing > > .get_dev_status() capability. > > > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > drivers/devfreq/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index > > 20373a893b44..e87d01c0b76a 100644 > > --- a/drivers/devfreq/Kconfig > > +++ b/drivers/devfreq/Kconfig > > @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ > > tristate "i.MX8M DDRC DEVFREQ Driver" > > depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \ > > (COMPILE_TEST && HAVE_ARM_SMCCC) > > - select DEVFREQ_GOV_SIMPLE_ONDEMAND > > select DEVFREQ_GOV_USERSPACE > > help > > This adds the DEVFREQ driver for the i.MX8M DDR Controller. It > > allows > > > > Looks good to me. But, How about changing the patch title as following? > - PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND > dependency Yes, good suggestion. Thanks I will resend v2. Regards Aisheng > > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics
diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 3fc3fd77492d..f3f6e25053ed 100644 --- a/drivers/devfreq/imx-bus.c +++ b/drivers/devfreq/imx-bus.c @@ -45,18 +45,6 @@ static int imx_bus_get_cur_freq(struct device *dev, unsigned long *freq) return 0; } -static int imx_bus_get_dev_status(struct device *dev, - struct devfreq_dev_status *stat) -{ - struct imx_bus *priv = dev_get_drvdata(dev); - - stat->busy_time = 0; - stat->total_time = 0; - stat->current_frequency = clk_get_rate(priv->clk); - - return 0; -} - static void imx_bus_exit(struct device *dev) { struct imx_bus *priv = dev_get_drvdata(dev); @@ -129,9 +117,7 @@ static int imx_bus_probe(struct platform_device *pdev) return ret; } - priv->profile.polling_ms = 1000; priv->profile.target = imx_bus_target; - priv->profile.get_dev_status = imx_bus_get_dev_status; priv->profile.exit = imx_bus_exit; priv->profile.get_cur_freq = imx_bus_get_cur_freq; priv->profile.initial_freq = clk_get_rate(priv->clk);
Current driver actually does not support simple ondemand governor as it's unable to provide device load information. So removing the unnecessary callback to avoid confusing. Right now the driver is using userspace governor by default. polling_ms was also dropped as it's not needed for non-ondemand governor. Cc: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/devfreq/imx-bus.c | 14 -------------- 1 file changed, 14 deletions(-)