diff mbox series

[v20,18/19] dt-bindings: mtd: pl353-nand: Describe this hardware controller

Message ID 20210519182636.1110080-19-miquel.raynal@bootlin.com
State New
Headers show
Series [v20,01/19] dt-binding: memory: pl353-smc: Rephrase the binding | expand

Commit Message

Miquel Raynal May 19, 2021, 6:26 p.m. UTC
Add a yaml description of this NAND controller which is described as a
subnode of the SMC bus.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

Comments

Rob Herring (Arm) May 20, 2021, 12:18 a.m. UTC | #1
On Wed, 19 May 2021 20:26:35 +0200, Miquel Raynal wrote:
> Add a yaml description of this NAND controller which is described as a

> subnode of the SMC bus.

> 

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---

>  .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 45 +++++++++++++++++++

>  1 file changed, 45 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

> 


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dts:21.11-33: Warning (reg_format): /example-0/nand-controller@0,0:reg: property has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: example-0: nand-controller@0,0:reg:0: [0, 0, 16777216] is too long
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml

See https://patchwork.ozlabs.org/patch/1481118

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Rob Herring (Arm) May 20, 2021, 8:56 p.m. UTC | #2
On Wed, May 19, 2021 at 08:26:35PM +0200, Miquel Raynal wrote:
> Add a yaml description of this NAND controller which is described as a

> subnode of the SMC bus.

> 

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---

>  .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 45 +++++++++++++++++++

>  1 file changed, 45 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

> 

> diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

> new file mode 100644

> index 000000000000..609726ed72de

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml

> @@ -0,0 +1,45 @@

> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: PL353 NAND Controller device tree bindings

> +

> +allOf:

> +  - $ref: "nand-controller.yaml"

> +

> +maintainers:

> +  - Miquel Raynal <miquel.raynal@bootlin.com>

> +  - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>

> +

> +properties:

> +  compatible:

> +    items:

> +      - enum:

> +          - arm,pl353-nand-r2p1

> +

> +  reg:

> +    items:

> +      - items:

> +        - description: CS with regard to the parent ranges property

> +        - description: Offset of the memory region requested by the device

> +        - description: Length of the memory region requested by the device

> +

> +  "#address-cells": true

> +  "#size-cells": true

> +

> +required:

> +  - compatible

> +  - reg

> +

> +additionalProperties: true


unevaluatedProperties: false

> +

> +examples:

> +  - |

> +    nand0: nand-controller@0,0 {

> +      compatible = "arm,pl353-nand-r2p1";

> +      reg = <0 0 0x1000000>;

> +      #address-cells = <1>;

> +      #size-cells = <0>;

> +    };

> -- 

> 2.27.0

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
new file mode 100644
index 000000000000..609726ed72de
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
@@ -0,0 +1,45 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/arm,pl353-nand-r2p1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PL353 NAND Controller device tree bindings
+
+allOf:
+  - $ref: "nand-controller.yaml"
+
+maintainers:
+  - Miquel Raynal <miquel.raynal@bootlin.com>
+  - Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - arm,pl353-nand-r2p1
+
+  reg:
+    items:
+      - items:
+        - description: CS with regard to the parent ranges property
+        - description: Offset of the memory region requested by the device
+        - description: Length of the memory region requested by the device
+
+  "#address-cells": true
+  "#size-cells": true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: true
+
+examples:
+  - |
+    nand0: nand-controller@0,0 {
+      compatible = "arm,pl353-nand-r2p1";
+      reg = <0 0 0x1000000>;
+      #address-cells = <1>;
+      #size-cells = <0>;
+    };