| Message ID | 20210519054030.3217704-1-swboyd@chromium.org |
|---|---|
| State | Accepted |
| Commit | 729046d4f1abf341b94d39036ad33506ea9f2c7a |
| Headers | show |
| Series | arm64: dts: qcom: sc7180-trogdor: Update flash freq to match reality | expand |
Bjorn, On Wed, May 19, 2021 at 9:05 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Tue, May 18, 2021 at 10:40 PM Stephen Boyd <swboyd@chromium.org> wrote: > > > > This spi flash part is actually being clocked at 37.5MHz, not 25MHz, > > because of the way the clk driver is rounding up the rate that is > > requested to the nearest supported frequency. Let's update the frequency > > here, and remove the TODO because this is the fastest frequency we're > > going to be able to use here. > > > > Cc: Douglas Anderson <dianders@chromium.org> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > --- > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > index 24d293ef56d7..af3c0e1e2223 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > @@ -335,8 +335,7 @@ flash@0 { > > compatible = "jedec,spi-nor"; > > reg = <0>; > > > > - /* TODO: Increase frequency after testing */ > > - spi-max-frequency = <25000000>; > > + spi-max-frequency = <37500000>; > > spi-tx-bus-width = <2>; > > spi-rx-bus-width = <2>; > > }; > > Thanks. Looks right to me. I confirmed that the clock is 150 MHz in my > "clk_summary" which is 4x 37.5. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> If you agree, I think this patch is ready to land. -Doug
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Tue, 18 May 2021 22:40:30 -0700 you wrote: > This spi flash part is actually being clocked at 37.5MHz, not 25MHz, > because of the way the clk driver is rounding up the rate that is > requested to the nearest supported frequency. Let's update the frequency > here, and remove the TODO because this is the fastest frequency we're > going to be able to use here. > > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > [...] Here is the summary with links: - arm64: dts: qcom: sc7180-trogdor: Update flash freq to match reality https://git.kernel.org/qcom/c/729046d4f1ab You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 24d293ef56d7..af3c0e1e2223 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -335,8 +335,7 @@ flash@0 { compatible = "jedec,spi-nor"; reg = <0>; - /* TODO: Increase frequency after testing */ - spi-max-frequency = <25000000>; + spi-max-frequency = <37500000>; spi-tx-bus-width = <2>; spi-rx-bus-width = <2>; };
This spi flash part is actually being clocked at 37.5MHz, not 25MHz, because of the way the clk driver is rounding up the rate that is requested to the nearest supported frequency. Let's update the frequency here, and remove the TODO because this is the fastest frequency we're going to be able to use here. Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5