| Message ID | 20210519124136.7938-1-thunder.leizhen@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] leds: blinkm: remove unused variable 'ret' in blinkm_init_hw() | expand |
On Wed 2021-05-19 20:41:36, Zhen Lei wrote: > GCC reports the following warning with W=1: > > drivers/leds/leds-blinkm.c:483:6: warning: > variable 'ret' set but not used [-Wunused-but-set-variable] > 483 | int ret; > | ^~~ > > This variable is not used, remove it to fix the warning. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Sounds like valid warning, and likely function should just propagate the error value. It would be good if someone with the hardware could take a look. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c index b4e1fdff4186..e34879b4c275 100644 --- a/drivers/leds/leds-blinkm.c +++ b/drivers/leds/leds-blinkm.c @@ -480,9 +480,8 @@ static int blinkm_led_blue_set(struct led_classdev *led_cdev, static void blinkm_init_hw(struct i2c_client *client) { - int ret; - ret = blinkm_transfer_hw(client, BLM_STOP_SCRIPT); - ret = blinkm_transfer_hw(client, BLM_GO_RGB); + (void)blinkm_transfer_hw(client, BLM_STOP_SCRIPT); + (void)blinkm_transfer_hw(client, BLM_GO_RGB); } static int blinkm_test_run(struct i2c_client *client)
GCC reports the following warning with W=1: drivers/leds/leds-blinkm.c:483:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 483 | int ret; | ^~~ This variable is not used, remove it to fix the warning. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/leds/leds-blinkm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.25.1