| Message ID | 1422626080-4614-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | New |
| Headers | show |
Sorry, should be ODP_WEAK_SYMBOL, not sure where my mind was. On 30 January 2015 at 11:39, Stuart Haslam <stuart.haslam@arm.com> wrote: > On Fri, Jan 30, 2015 at 01:54:40PM +0000, Mike Holmes wrote: > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > --- > > platform/linux-generic/odp_packet_socket.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/platform/linux-generic/odp_packet_socket.c > b/platform/linux-generic/odp_packet_socket.c > > index 3f114fa..0fda129 100644 > > --- a/platform/linux-generic/odp_packet_socket.c > > +++ b/platform/linux-generic/odp_packet_socket.c > > @@ -48,7 +48,8 @@ > > * As it is implemented as a weak symbol, it has zero effect on systems > > * with both. > > */ > > -int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int > flags) __attribute__((weak)); > > +int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int > flags) > > + ODP_UNUSED; > > int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int > flags) > > { > > #ifdef SYS_sendmmsg > > I'm not sure why this change is needed. The function is used. Also why > are you dropping the weak attribute? > > -- > Stuart. > >
diff --git a/platform/linux-generic/odp_packet_socket.c b/platform/linux-generic/odp_packet_socket.c index 3f114fa..0fda129 100644 --- a/platform/linux-generic/odp_packet_socket.c +++ b/platform/linux-generic/odp_packet_socket.c @@ -48,7 +48,8 @@ * As it is implemented as a weak symbol, it has zero effect on systems * with both. */ -int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int flags) __attribute__((weak)); +int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int flags) + ODP_UNUSED; int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int flags) { #ifdef SYS_sendmmsg
Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- platform/linux-generic/odp_packet_socket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)