| Message ID | 20210517105113.240379-4-stephan@gerhold.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix RT5033 battery device tree probing | expand |
On Mon, 17 May 2021, Stephan Gerhold wrote: > The fuel gauge in the RT5033 PMIC (rt5033-battery) has its own I2C bus > and interrupt lines. Therefore, it is not part of the MFD device > and needs to be specified separately in the device tree. > > Cc: Beomho Seo <beomho.seo@samsung.com> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- > drivers/mfd/rt5033.c | 3 --- > 1 file changed, 3 deletions(-) Acked-by: Lee Jones <lee.jones@linaro.org>
Hi Lee, On Wed, May 19, 2021 at 03:46:30PM +0100, Lee Jones wrote: > On Mon, 17 May 2021, Stephan Gerhold wrote: > > > The fuel gauge in the RT5033 PMIC (rt5033-battery) has its own I2C bus > > and interrupt lines. Therefore, it is not part of the MFD device > > and needs to be specified separately in the device tree. > > > > Cc: Beomho Seo <beomho.seo@samsung.com> > > Cc: Chanwoo Choi <cw00.choi@samsung.com> > > Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.") > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > > --- > > drivers/mfd/rt5033.c | 3 --- > > 1 file changed, 3 deletions(-) > > Acked-by: Lee Jones <lee.jones@linaro.org> > Since I mentioned in the cover letter that the MFD and power supply changes can be applied independently, Sebastian only queued patch 1 and 2. Can you queue this one through the MFD tree? Thanks! Stephan
diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index f1236a9acf30..df095e91e266 100644 --- a/drivers/mfd/rt5033.c +++ b/drivers/mfd/rt5033.c @@ -41,9 +41,6 @@ static const struct mfd_cell rt5033_devs[] = { { .name = "rt5033-charger", .of_compatible = "richtek,rt5033-charger", - }, { - .name = "rt5033-battery", - .of_compatible = "richtek,rt5033-battery", }, { .name = "rt5033-led", .of_compatible = "richtek,rt5033-led",
The fuel gauge in the RT5033 PMIC (rt5033-battery) has its own I2C bus and interrupt lines. Therefore, it is not part of the MFD device and needs to be specified separately in the device tree. Cc: Beomho Seo <beomho.seo@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.") Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- drivers/mfd/rt5033.c | 3 --- 1 file changed, 3 deletions(-)