| Message ID | 20210511153958.34527-2-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/4] lib/vsprintf: Allow to override ISO 8601 date and time separator | expand |
On Tue, May 11, 2021 at 06:39:56PM +0300, Andy Shevchenko wrote: > Use %ptTs instead of open-coded variant to print contents > of time64_t type in human readable form. > > Cc: Jason Wessel <jason.wessel@windriver.com> > Cc: Daniel Thompson <daniel.thompson@linaro.org> > Cc: kgdb-bugreport@lists.sourceforge.net > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Petr Mladek <pmladek@suse.com> > Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Any clue what route this will take into the kernel? I'm certainly happy for someone else to take the kdb bits alongside the vsprintf stuff (so here's an acked-by too in case they are fussy about that sort of thing ;-) ): Acked-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel. > --- > v2: collected tags > kernel/debug/kdb/kdb_main.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c > index 1baa96a2ecb8..622410c45da1 100644 > --- a/kernel/debug/kdb/kdb_main.c > +++ b/kernel/debug/kdb/kdb_main.c > @@ -2488,7 +2488,6 @@ static void kdb_sysinfo(struct sysinfo *val) > static int kdb_summary(int argc, const char **argv) > { > time64_t now; > - struct tm tm; > struct sysinfo val; > > if (argc) > @@ -2502,13 +2501,7 @@ static int kdb_summary(int argc, const char **argv) > kdb_printf("domainname %s\n", init_uts_ns.name.domainname); > > now = __ktime_get_real_seconds(); > - time64_to_tm(now, 0, &tm); > - kdb_printf("date %04ld-%02d-%02d %02d:%02d:%02d " > - "tz_minuteswest %d\n", > - 1900+tm.tm_year, tm.tm_mon+1, tm.tm_mday, > - tm.tm_hour, tm.tm_min, tm.tm_sec, > - sys_tz.tz_minuteswest); > - > + kdb_printf("date %ptTs tz_minuteswest %d\n", &now, sys_tz.tz_minuteswest); > kdb_sysinfo(&val); > kdb_printf("uptime "); > if (val.uptime > (24*60*60)) { > -- > 2.30.2 >
On Thu, May 13, 2021 at 10:31:30AM +0100, Daniel Thompson wrote: > On Tue, May 11, 2021 at 06:39:56PM +0300, Andy Shevchenko wrote: > > Use %ptTs instead of open-coded variant to print contents > > of time64_t type in human readable form. > > > > Cc: Jason Wessel <jason.wessel@windriver.com> > > Cc: Daniel Thompson <daniel.thompson@linaro.org> > > Cc: kgdb-bugreport@lists.sourceforge.net > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Petr Mladek <pmladek@suse.com> > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > Any clue what route this will take into the kernel? I'm certainly happy > for someone else to take the kdb bits alongside the vsprintf stuff > (so here's an acked-by too in case they are fussy about that sort of > thing ;-) ): I hope Petr will take it thru PRINTK tree. > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> Thanks! -- With Best Regards, Andy Shevchenko
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 1baa96a2ecb8..622410c45da1 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -2488,7 +2488,6 @@ static void kdb_sysinfo(struct sysinfo *val) static int kdb_summary(int argc, const char **argv) { time64_t now; - struct tm tm; struct sysinfo val; if (argc) @@ -2502,13 +2501,7 @@ static int kdb_summary(int argc, const char **argv) kdb_printf("domainname %s\n", init_uts_ns.name.domainname); now = __ktime_get_real_seconds(); - time64_to_tm(now, 0, &tm); - kdb_printf("date %04ld-%02d-%02d %02d:%02d:%02d " - "tz_minuteswest %d\n", - 1900+tm.tm_year, tm.tm_mon+1, tm.tm_mday, - tm.tm_hour, tm.tm_min, tm.tm_sec, - sys_tz.tz_minuteswest); - + kdb_printf("date %ptTs tz_minuteswest %d\n", &now, sys_tz.tz_minuteswest); kdb_sysinfo(&val); kdb_printf("uptime "); if (val.uptime > (24*60*60)) {