Hi! > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ] > > WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this. > This was working so far due to a shift bug in gpio driver, however > once that is fixed this will stop working, so fix this! I don't see the correspoing update to the driver this talks about. Do we have corresponding driver in 5.10 and was it fixed to match? Best regards, Pavel > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -1015,7 +1015,7 @@ > left_spkr: wsa8810-left{ > compatible = "sdw10217201000"; > reg = <0 1>; > - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; > + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; > #thermal-sensor-cells = <0>; > sound-name-prefix = "SpkrLeft"; > #sound-dai-cells = <0>; > @@ -1023,7 +1023,7 @@ > > right_spkr: wsa8810-right{ > compatible = "sdw10217201000"; > - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; > + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; > reg = <0 2>; > #thermal-sensor-cells = <0>; > sound-name-prefix = "SpkrRight"; -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
+ Adding Linus W and Bartosz to CC. On 15/05/2021 09:18, Pavel Machek wrote: > Hi! > >> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> >> [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ] >> >> WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this. >> This was working so far due to a shift bug in gpio driver, however >> once that is fixed this will stop working, so fix this! > > I don't see the correspoing update to the driver this talks about. > > Do we have corresponding driver in 5.10 and was it fixed to match? This corresponding gpio driver patch was submitted along with the original fix, however it looks like it was not picked up yet. https://www.spinics.net/lists/linux-gpio/msg59264.html Bartosz/Linus W, Do you want me to resend this? --srini > > Best regards, > Pavel > >> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts >> @@ -1015,7 +1015,7 @@ >> left_spkr: wsa8810-left{ >> compatible = "sdw10217201000"; >> reg = <0 1>; >> - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; >> + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; >> #thermal-sensor-cells = <0>; >> sound-name-prefix = "SpkrLeft"; >> #sound-dai-cells = <0>; >> @@ -1023,7 +1023,7 @@ >> >> right_spkr: wsa8810-right{ >> compatible = "sdw10217201000"; >> - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; >> + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; >> reg = <0 2>; >> #thermal-sensor-cells = <0>; >> sound-name-prefix = "SpkrRight"; >
On Mon, May 17, 2021 at 10:46 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > Do we have corresponding driver in 5.10 and was it fixed to match? > > This corresponding gpio driver patch was submitted along with the > original fix, however it looks like it was not picked up yet. > > https://www.spinics.net/lists/linux-gpio/msg59264.html > > Bartosz/Linus W, Do you want me to resend this? OMG how could we have missed this patch with so many ACKs. Please rebase on v5.13-rc1 and resend with all ACKs so that Bartosz can apply it. Yours, Linus Walleij
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index c4ac6f5dc008..96d36b38f269 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -1015,7 +1015,7 @@ left_spkr: wsa8810-left{ compatible = "sdw10217201000"; reg = <0 1>; - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrLeft"; #sound-dai-cells = <0>; @@ -1023,7 +1023,7 @@ right_spkr: wsa8810-right{ compatible = "sdw10217201000"; - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; reg = <0 2>; #thermal-sensor-cells = <0>; sound-name-prefix = "SpkrRight";