| Message ID | 1421920133-7914-2-git-send-email-lee.jones@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Fri, 23 Jan 2015, Thomas Gleixner wrote: > On Thu, 22 Jan 2015, Lee Jones wrote: > > > These defines are used to allow values used for configuration to be > > easily human readable and will lessen the chance of logical mistakes. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h > > > > diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h > > new file mode 100644 > > index 0000000..4c59ace > > --- /dev/null > > +++ b/include/dt-bindings/interrupt-controller/irq-st.h > > @@ -0,0 +1,30 @@ > > +/* > > + * include/linux/irqchip/irq-st.h > > Copy & Paste? > > Can we please stop adding these pointless filenames all over the > place? They are useless and wrong in a lot of cases. Less of a copy and paste and more and a `mv` without fixing up the file names. I guess they are silly, but they are rife, so someone must think they're a good idea. :) for file in `find drivers -name *.c`; do head $file | grep "\.c$"; done > Aside of that, this needs an ack from the DT folks. I think you'll be lucky. I haven't seen a DT review for some time now. Perhaps, as it's you, this might be different. ;)
diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h new file mode 100644 index 0000000..4c59ace --- /dev/null +++ b/include/dt-bindings/interrupt-controller/irq-st.h @@ -0,0 +1,30 @@ +/* + * include/linux/irqchip/irq-st.h + * + * Copyright (C) 2014 STMicroelectronics – All Rights Reserved + * + * Author: Lee Jones <lee.jones@linaro.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_ST_H +#define _DT_BINDINGS_INTERRUPT_CONTROLLER_ST_H + +#define ST_IRQ_SYSCFG_EXT_0 0 +#define ST_IRQ_SYSCFG_EXT_1 1 +#define ST_IRQ_SYSCFG_EXT_2 2 +#define ST_IRQ_SYSCFG_CTI_0 3 +#define ST_IRQ_SYSCFG_CTI_1 4 +#define ST_IRQ_SYSCFG_PMU_0 5 +#define ST_IRQ_SYSCFG_PMU_1 6 +#define ST_IRQ_SYSCFG_pl310_L2 7 +#define ST_IRQ_SYSCFG_DISABLED 0xFFFFFFFF + +#define ST_IRQ_SYSCFG_EXT_1_INV 0x1 +#define ST_IRQ_SYSCFG_EXT_2_INV 0x2 +#define ST_IRQ_SYSCFG_EXT_3_INV 0x4 + +#endif
These defines are used to allow values used for configuration to be easily human readable and will lessen the chance of logical mistakes. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h