@@ -2892,8 +2892,15 @@ brcmf_cfg80211_dump_station(struct wiphy *wiphy, struct net_device *ndev,
&cfg->assoclist,
sizeof(cfg->assoclist));
if (err) {
- bphy_err(drvr, "BRCMF_C_GET_ASSOCLIST unsupported, err=%d\n",
- err);
+ static bool error_printed = false;
+
+ /* GET_ASSOCLIST unsupported by firmware of older chips */
+ if (!error_printed || err != -EBADE) {
+ bphy_err(drvr, "BRCMF_C_GET_ASSOCLIST unsupported, err=%d\n",
+ err);
+ error_printed = true;
+ }
+
cfg->assoclist.count = 0;
return -EOPNOTSUPP;
}
@@ -188,9 +188,16 @@ static void _brcmf_set_multicast_list(struct work_struct *work)
/*Finally, pick up the PROMISC flag */
cmd_value = (ndev->flags & IFF_PROMISC) ? true : false;
err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PROMISC, cmd_value);
- if (err < 0)
- bphy_err(drvr, "Setting BRCMF_C_SET_PROMISC failed, %d\n",
- err);
+ if (err < 0) {
+ static bool error_printed = false;
+
+ /* PROMISC unsupported by firmware of older chips */
+ if (!error_printed || err != -EBADE) {
+ bphy_err(drvr, "Setting BRCMF_C_SET_PROMISC unsupported, err=%d\n",
+ err);
+ error_printed = true;
+ }
+ }
brcmf_configure_arp_nd_offload(ifp, !cmd_value);
}
KMSG is flooded with error messages about unsupported firmware features on BCM4329 chip. The GET_ASSOCLIST error became especially noisy with a newer NetworkManager version of Ubuntu 21.04. Let's print the noisy error messages only once. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 11 +++++++++-- .../net/wireless/broadcom/brcm80211/brcmfmac/core.c | 13 ++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-)