| Message ID | 20150118051111.31866.39208.stgit@114-36-241-182.dynamic.hinet.net |
|---|---|
| State | New |
| Headers | show |
On 10 February 2015 at 01:54, Bjorn Andersson <bjorn@kryo.se> wrote: > On Sat, Jan 17, 2015 at 9:11 PM, Andy Green <andy.green@linaro.org> wrote: >> WCN3620 powersaving mode is not stable. Disable it if we're >> on a wcn3620 chip type. >> >> Signed-off-by: Andy Green <andy.green@linaro.org> >> --- >> drivers/net/wireless/ath/wcn36xx/main.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c >> index c4178c7..569d45b 100644 >> --- a/drivers/net/wireless/ath/wcn36xx/main.c >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c >> @@ -924,6 +924,10 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) >> IEEE80211_HW_AMPDU_AGGREGATION | >> IEEE80211_HW_TIMING_BEACON_ONLY; >> >> + /* 3620 powersaving currently unstable */ >> + if (wcn->chip_version == WCN36XX_CHIP_3620) >> + wcn->hw->flags &= ~IEEE80211_HW_SUPPORTS_PS; >> + > > Hi Andy, > > I have the same problem (Data Abort Exception in wcnss) on 3680, this > with my wip smd code and a hacked up remoteproc-pil. I haven't spent > any effort on debugging this, but it looks like it's something related > to what we have ported to mainline (or lack thereof) rather than a > 3620 specific issue. Makes sense since I only have 3620, I assumed it's related to that. However he can work for a while with powersaving on, but ping latencies are +600-800ms and he's shaky. Later I found something mac80211 generic scan preparation or post-scan code (for scan initiated by wpa_supplicant) is able to stop wlan traffic after a few goes even if the actual scan mode smd is not sent. At that point I think a nice solution would be a donation of time from guys who specialize in wcn for a living to come and hand out a pony or two... -Andy > Regards, > Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index c4178c7..569d45b 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -924,6 +924,10 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) IEEE80211_HW_AMPDU_AGGREGATION | IEEE80211_HW_TIMING_BEACON_ONLY; + /* 3620 powersaving currently unstable */ + if (wcn->chip_version == WCN36XX_CHIP_3620) + wcn->hw->flags &= ~IEEE80211_HW_SUPPORTS_PS; + wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_AP) | BIT(NL80211_IFTYPE_ADHOC) |
WCN3620 powersaving mode is not stable. Disable it if we're on a wcn3620 chip type. Signed-off-by: Andy Green <andy.green@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++++ 1 file changed, 4 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html