| Message ID | 1421172890-29763-1-git-send-email-julien.grall@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Jan, On 14/01/15 07:11, Jan Beulich wrote: >>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>> >> QEMU upstream requires the use of pixman. When pixman is not present the >> system, the configure of QEMU will fail with: >> >> ERROR: pixman not present. Your options: >> (1) Preferred: Install the pixman devel package (any recent >> distro should have packages as Xorg needs pixman too). >> (2) Fetch the pixman submodule, using: >> git submodule update --init pixman >> >> I think we can use by default the version on the system. So check it >> a Xen configuration time to avoid a build issue later. > > Since qemu building isn't a required part of building the tools, is a check in > the tools configure process really an appropriate thing to do? QEMU is a required part of building the tools. Any failure to build QEMU will make Xen tools build fail. It's reproductible with "make install-tools" and pixman not installed. Regards,
On 14/01/15 12:24, Ian Campbell wrote: > On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote: >> Hi Jan, >> >> On 14/01/15 07:11, Jan Beulich wrote: >>>>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>> >>>> QEMU upstream requires the use of pixman. When pixman is not present the >>>> system, the configure of QEMU will fail with: >>>> >>>> ERROR: pixman not present. Your options: >>>> (1) Preferred: Install the pixman devel package (any recent >>>> distro should have packages as Xorg needs pixman too). >>>> (2) Fetch the pixman submodule, using: >>>> git submodule update --init pixman >>>> >>>> I think we can use by default the version on the system. So check it >>>> a Xen configuration time to avoid a build issue later. >>> >>> Since qemu building isn't a required part of building the tools, is a check in >>> the tools configure process really an appropriate thing to do? >> >> QEMU is a required part of building the tools. > > Not stricty true. Pass --with-system-qemu if you wish to avoid it. Right. So the check for glib in the configure for ARM is not necessary when --with-system-qemu is used. Might be interesting to avoid checking dependency that is not useful. Regards,
On 14/01/15 12:31, Ian Campbell wrote: > On Wed, 2015-01-14 at 12:28 +0000, Julien Grall wrote: >> On 14/01/15 12:24, Ian Campbell wrote: >>> On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote: >>>> Hi Jan, >>>> >>>> On 14/01/15 07:11, Jan Beulich wrote: >>>>>>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>> >>>>>> QEMU upstream requires the use of pixman. When pixman is not present the >>>>>> system, the configure of QEMU will fail with: >>>>>> >>>>>> ERROR: pixman not present. Your options: >>>>>> (1) Preferred: Install the pixman devel package (any recent >>>>>> distro should have packages as Xorg needs pixman too). >>>>>> (2) Fetch the pixman submodule, using: >>>>>> git submodule update --init pixman >>>>>> >>>>>> I think we can use by default the version on the system. So check it >>>>>> a Xen configuration time to avoid a build issue later. >>>>> >>>>> Since qemu building isn't a required part of building the tools, is a check in >>>>> the tools configure process really an appropriate thing to do? >>>> >>>> QEMU is a required part of building the tools. >>> >>> Not stricty true. Pass --with-system-qemu if you wish to avoid it. >> >> Right. So the check for glib in the configure for ARM is not necessary >> when --with-system-qemu is used. >> >> Might be interesting to avoid checking dependency that is not useful. > > I didn't think it was worth it, but given the objections perhaps putting > all the checks which are there solely for qemu-upstream under a > conditional based on --with-system-qemu is the way to go. On x86, glib seems to be required for seabios and ipxe. Regards,
On 14/01/15 12:38, Ian Campbell wrote: > On Wed, 2015-01-14 at 12:32 +0000, Julien Grall wrote: >> On x86, glib seems to be required for seabios > > Only for make gtkconfig, I think? (surely the actual BIOS doesn't need > glib!). We won't use that in our own builds I think. Ok. > >> and ipxe. > > Really? My mistake I grepped too quickly. So I will change this patch for checking if qemu-system is used. Regards,
diff --git a/tools/configure.ac b/tools/configure.ac index 1ac63a3..321b645 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -325,6 +325,7 @@ esac AX_CHECK_UUID AX_CHECK_CURSES PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12]) +PKG_CHECK_MODULES(pixman, pixman-1) AX_CHECK_FETCHER # Checks for libraries.
QEMU upstream requires the use of pixman. When pixman is not present the system, the configure of QEMU will fail with: ERROR: pixman not present. Your options: (1) Preferred: Install the pixman devel package (any recent distro should have packages as Xorg needs pixman too). (2) Fetch the pixman submodule, using: git submodule update --init pixman I think we can use by default the version on the system. So check it a Xen configuration time to avoid a build issue later. Signed-off-by: Julien Grall <julien.grall@linaro.org> --- This patch requires to regenerate tools/configure. --- tools/configure.ac | 1 + 1 file changed, 1 insertion(+)