| Message ID | 20210503180538.64423-1-matthijs@stdin.nl |
|---|---|
| State | New |
| Headers | show |
| Series | usb: dwc2: Remove obsolete MODULE_ constants from platform.c | expand |
On 5/3/2021 10:05 PM, Matthijs Kooijman wrote: > Originally, the core and platform drivers were separate modules, so each > had its own module info. Since commit 2d1165a4b95e (usb: dwc2: remove > dwc2_platform.ko) platform.c is included in the core module, which now > contains duplicate module info (from core.c and platform.c). > > Due to the linking order and modinfo implementation, running `modinfo` > on the resulting dwc2.ko shows just the info from platform.c, rather > than that from core.c, suggesting that I am the author of the entire > dwc2 module. Since platform.c is just a minor part of the entire module, > this removes its module info in favor of the info from core.c. > > Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl> Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> > --- > drivers/usb/dwc2/platform.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c > index 5f18acac7406..e1e1e32e0008 100644 > --- a/drivers/usb/dwc2/platform.c > +++ b/drivers/usb/dwc2/platform.c > @@ -742,7 +742,3 @@ static struct platform_driver dwc2_platform_driver = { > }; > > module_platform_driver(dwc2_platform_driver); > - > -MODULE_DESCRIPTION("DESIGNWARE HS OTG Platform Glue"); > -MODULE_AUTHOR("Matthijs Kooijman <matthijs@stdin.nl>"); > -MODULE_LICENSE("Dual BSD/GPL"); >
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 5f18acac7406..e1e1e32e0008 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -742,7 +742,3 @@ static struct platform_driver dwc2_platform_driver = { }; module_platform_driver(dwc2_platform_driver); - -MODULE_DESCRIPTION("DESIGNWARE HS OTG Platform Glue"); -MODULE_AUTHOR("Matthijs Kooijman <matthijs@stdin.nl>"); -MODULE_LICENSE("Dual BSD/GPL");
Originally, the core and platform drivers were separate modules, so each had its own module info. Since commit 2d1165a4b95e (usb: dwc2: remove dwc2_platform.ko) platform.c is included in the core module, which now contains duplicate module info (from core.c and platform.c). Due to the linking order and modinfo implementation, running `modinfo` on the resulting dwc2.ko shows just the info from platform.c, rather than that from core.c, suggesting that I am the author of the entire dwc2 module. Since platform.c is just a minor part of the entire module, this removes its module info in favor of the info from core.c. Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl> --- drivers/usb/dwc2/platform.c | 4 ---- 1 file changed, 4 deletions(-)