diff mbox

[PATCHv3] linux-generic: buffers: remove vestigial asserts for 32-bit support

Message ID 1420756465-13078-1-git-send-email-bill.fischofer@linaro.org
State Accepted
Commit cf2e3c1db3ca63af60f2c9fbd83a1045902440a0
Headers show

Commit Message

Bill Fischofer Jan. 8, 2015, 10:34 p.m. UTC
Fix for Bug 1031 to enable linux-generic compiles on 32-bit systems.

Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---
 platform/linux-generic/include/odp_buffer_internal.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Mike Holmes Jan. 9, 2015, 6:33 p.m. UTC | #1
Any reviews to get this in 0.7.0 as planned ?

On 8 January 2015 at 17:34, Bill Fischofer <bill.fischofer@linaro.org>
wrote:

> Fix for Bug 1031 to enable linux-generic compiles on 32-bit systems.
>
> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
> ---
>  platform/linux-generic/include/odp_buffer_internal.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/platform/linux-generic/include/odp_buffer_internal.h
> b/platform/linux-generic/include/odp_buffer_internal.h
> index 60f06c9..c64802b 100644
> --- a/platform/linux-generic/include/odp_buffer_internal.h
> +++ b/platform/linux-generic/include/odp_buffer_internal.h
> @@ -136,9 +136,6 @@ typedef struct odp_buffer_hdr_t {
>  typedef struct odp_buffer_hdr_stride {
>         uint8_t pad[ODP_CACHE_LINE_SIZE_ROUNDUP(sizeof(odp_buffer_hdr_t))];
>  } odp_buffer_hdr_stride;
> -/* Ensure next header starts from 8 byte align */
> -_ODP_STATIC_ASSERT((sizeof(odp_buffer_hdr_t) % 8) == 0,
> -                  "ODP_BUFFER_HDR_T__SIZE_ERROR");
>
>  typedef struct odp_buf_blk_t {
>         struct odp_buf_blk_t *next;
> --
> 2.1.0
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
Mike Holmes Jan. 9, 2015, 7:28 p.m. UTC | #2
Applied

On 9 January 2015 at 14:07, Shmulik Ladkani <shmulik.ladkani@gmail.com>
wrote:

> On Thu,  8 Jan 2015 16:34:25 -0600 Bill Fischofer <
> bill.fischofer@linaro.org> wrote:
> > Fix for Bug 1031 to enable linux-generic compiles on 32-bit systems.
> >
> > Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
>
> Reviewed-and-tested-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>
diff mbox

Patch

diff --git a/platform/linux-generic/include/odp_buffer_internal.h b/platform/linux-generic/include/odp_buffer_internal.h
index 60f06c9..c64802b 100644
--- a/platform/linux-generic/include/odp_buffer_internal.h
+++ b/platform/linux-generic/include/odp_buffer_internal.h
@@ -136,9 +136,6 @@  typedef struct odp_buffer_hdr_t {
 typedef struct odp_buffer_hdr_stride {
 	uint8_t pad[ODP_CACHE_LINE_SIZE_ROUNDUP(sizeof(odp_buffer_hdr_t))];
 } odp_buffer_hdr_stride;
-/* Ensure next header starts from 8 byte align */
-_ODP_STATIC_ASSERT((sizeof(odp_buffer_hdr_t) % 8) == 0,
-		   "ODP_BUFFER_HDR_T__SIZE_ERROR");
 
 typedef struct odp_buf_blk_t {
 	struct odp_buf_blk_t *next;