diff mbox series

AW: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify code

Message ID c621542318e644239008eea5f670390e@bfs.de
State New
Headers show
Series AW: [PATCH] crypto: cavium - Use 'hlist_for_each_entry' to simplify code | expand

Commit Message

Walter Harms April 28, 2021, 9:34 a.m. UTC 
It is also possible to drop the else and simplify
further.

hlist_for_each_entry(chunk, &queue->chead, nextchunk)
if (chunk != queue->qhead) {
                                queue->qhead = chunk;
                                break;
                        }

re,
 wh
diff mbox series

Patch

diff --git a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
index 4fe7898c8561..feb0f76783dd 100644
--- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
+++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c
@@ -244,11 +244,7 @@  static int send_cpt_command(struct cpt_vf *cptvf, union cpt_inst_s *cmd,
        memcpy(ent, (void *)cmd, qinfo->cmd_size);

        if (++queue->idx >= queue->qhead->size / 64) {
-               struct hlist_node *node;
-
-               hlist_for_each(node, &queue->chead) {
-                       chunk = hlist_entry(node, struct command_chunk,
-                                           nextchunk);
+               hlist_for_each_entry(chunk, &queue->chead, nextchunk) {
                        if (chunk == queue->qhead) {
                                continue;
                        } else {